[LVL control] Return invalid command on move when rate is 0 or rate is null and de… #33204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
jmartinez-silabs
force-pushed
the
fix/lvl_MoveWithOnOff_0
branch
from
9ca6e17 to
13761fc
Compare
|
PR #33204: Size comparison from 8ba371a to 13761fc Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
…n at function entry
…n value of default move rate to 1 per spec
…ing it with update_cluster_revisions.py and regen
…e Rate in TC_LVL_2_1
jmartinez-silabs
force-pushed
the
fix/lvl_MoveWithOnOff_0
branch
from
13761fc to
d8de73f
Compare
|
PR #33204: Size comparison from 2fddae4 to d8de73f Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #33204: Size comparison from 2fddae4 to 2a1bc4f Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 19, 2024
andy31415
approved these changes
Jul 19, 2024
bzbarsky-apple
approved these changes
Jul 19, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…s null and de… (project-chip#33204) * Return invalid command on move when rate is 0 or rate is null and defaultRate is 0 * Update src/app/clusters/level-control/level-control.cpp Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> * Add check for stepSize and stepMode and move the parameters validation at function entry * Update level-control-cluster.xml to bump revision to 6 and set the min value of default move rate to 1 per spec * Update level control cluster revision from 5 to 6 in all zap files using it with update_cluster_revisions.py and regen * bump expected cluster revision in test TC_LVL_1_1 and min default Move Rate in TC_LVL_2_1 * rebase and regen all * Zap regen post rebase * address comments --------- Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…faultRate is 0
This PR syncs the SDK in line with this spec PR
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/9140
As a move of 0 doesn't make much sense.
Details about the decision can be found in this Slack thread
https://csamembers.slack.com/archives/C01EWUSBT0C/p1713794720672179
I also update the test plan to change the expected command response:
https://github.com/CHIP-Specifications/chip-test-plans/pull/4139
Edit: Latest updates