-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python platform for perfetto submodule #33246
Conversation
We need this to compile the python wheel, which is not strictly one of the host platforms. Adding a python platform designation so we can specify this submodule without pulling in the other host platform dependencies.
PR #33246: Size comparison from 335ae19 to f3ecdbc Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
@cecille is the python wheel not compiling C++ code, so it would need either darwin or linux dependencies (e.g. our wheel accesses blutooth and dnssd so it may need those underlying libraries) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking request changes for now: I am unclear how we compile python without native bits. This needs to be explained.
Until now we only ever compiled python whl with native bits and then we depend on linux or darwin submodules.
This is submodule specific, trying not to pull in the world. I'd rather not shave this particular yak today, so closing. |
We need this to compile the python wheel, which is not strictly one of the host platforms. Adding a python platform designation so we can specify this submodule without pulling in the other host platform dependencies.