Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chip-tool] Not register LIT at default #33262

Merged
2 changes: 1 addition & 1 deletion examples/chip-tool/commands/pairing/PairingCommand.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ CommissioningParameters PairingCommand::GetCommissioningParameters()
params.SetDSTOffsets(mDSTOffsetList);
}

if (!mSkipICDRegistration.ValueOr(false))
if (mICDRegistration.ValueOr(true))
{
params.SetICDRegistrationStrategy(ICDRegistrationStrategy::kBeforeComplete);

Expand Down
6 changes: 3 additions & 3 deletions examples/chip-tool/commands/pairing/PairingCommand.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ class PairingCommand : public CHIPCommand,
"Bypass the attestation verifier. If not provided or false, the attestation verifier is not bypassed."
" If true, the commissioning will continue in case of attestation verification failure.");
AddArgument("case-auth-tags", 1, UINT32_MAX, &mCASEAuthTags, "The CATs to be encoded in the NOC sent to the commissionee");
AddArgument("skip-icd-registration", 0, 1, &mSkipICDRegistration,
"Skip registering for check-ins from ICDs during commissioning. Default: false");
AddArgument("icd-registration", 0, 1, &mICDRegistration,
"registering for check-ins from ICDs during commissioning. Default: false");
AddArgument("icd-check-in-nodeid", 0, UINT64_MAX, &mICDCheckInNodeId,
"The check-in node id for the ICD, default: node id of the commissioner.");
AddArgument("icd-monitored-subject", 0, UINT64_MAX, &mICDMonitoredSubject,
Expand Down Expand Up @@ -233,7 +233,7 @@ class PairingCommand : public CHIPCommand,
chip::Optional<bool> mBypassAttestationVerifier;
chip::Optional<std::vector<uint32_t>> mCASEAuthTags;
chip::Optional<char *> mCountryCode;
chip::Optional<bool> mSkipICDRegistration;
chip::Optional<bool> mICDRegistration;
chip::Optional<NodeId> mICDCheckInNodeId;
chip::Optional<chip::ByteSpan> mICDSymmetricKey;
chip::Optional<uint64_t> mICDMonitoredSubject;
Expand Down
3 changes: 2 additions & 1 deletion scripts/tests/chiptest/test_definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,8 @@ def Run(self, runner, apps_register, paths: ApplicationPaths, pics_file: str,
runner.RunSubprocess(python_cmd, name='CHIP_REPL_YAML_TESTER',
dependencies=[apps_register], timeout_seconds=timeout_seconds)
else:
pairing_cmd = paths.chip_tool_with_python_cmd + ['pairing', 'code', TEST_NODE_ID, setupCode]
pairing_cmd = paths.chip_tool_with_python_cmd + \
['pairing', 'code', TEST_NODE_ID, setupCode, '--icd-registration', 'false']
test_cmd = paths.chip_tool_with_python_cmd + ['tests', self.run_name] + ['--PICS', pics_file]
server_args = ['--server_path', paths.chip_tool[-1]] + \
['--server_arguments', 'interactive server' +
Expand Down
Loading