-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS tv-casting-app: deleting dead code #33394
Merged
sharadb-amazon
merged 1 commit into
project-chip:master
from
sharadb-amazon:del-20240509
May 9, 2024
Merged
iOS tv-casting-app: deleting dead code #33394
sharadb-amazon
merged 1 commit into
project-chip:master
from
sharadb-amazon:del-20240509
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgregorr-amazon
approved these changes
May 9, 2024
PR #33394: Size comparison from d653df1 to a67671b Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
woody-apple
approved these changes
May 9, 2024
andy31415
approved these changes
May 9, 2024
chrisdecenzo
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #33350
Change Sumary
The previous PR already moved the updated versions of the files in this diff to the
compat-shim
directory. As such, the files in this diff are the older versions in the original directory and are dead code, which this PR deletes.Testing
Tested that the build of the iOS tv-casting-app succeeds and there are no functional changes.