-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple CommandHandler.h/cpp
from the BUILD.gn build rules of app/interaction-model
#33595
Merged
mergify
merged 5 commits into
project-chip:master
from
andy31415:command_handler_header_decoupled
May 28, 2024
Merged
Decouple CommandHandler.h/cpp
from the BUILD.gn build rules of app/interaction-model
#33595
mergify
merged 5 commits into
project-chip:master
from
andy31415:command_handler_header_decoupled
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufengwangca
approved these changes
May 24, 2024
PR #33595: Size comparison from 7453a11 to 9f26d01 Decreases (1 build for mbed)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #33595: Size comparison from 7453a11 to 895b9b3 Increases (5 builds for cyw30739, esp32, linux)
Decreases (60 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, stm32, telink)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
tehampson
approved these changes
May 27, 2024
jmartinez-silabs
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes CommandHandler reasonably stand-alone to be referenced without pulling in a dependency on the entire interactionmodelengine. Given that includes are not circular anymore.
Changes
app/BUILD.gn
such that things can be compiled/included independently. Final end result is that:command-handler
is its own stand-alone item that does not depend on app or im. Had to pull out "status-response" as well as "required-privileges", did not try to group these further