-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to add pending fabric at a chosen fabric index #33646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33646: Size comparison from 8c8889b to 76ea311 Increases (3 builds for nrfconnect)
Full report (7 builds for cc32xx, mbed, nrfconnect, stm32)
|
76ea311
to
6af5226
Compare
PR #33646: Size comparison from 8c8889b to 6af5226 Increases (19 builds for nrfconnect, telink)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, stm32, telink)
|
PR #33646: Size comparison from 8c8889b to a61b52e Increases (33 builds for cc13x4_26x4, esp32, linux, nrfconnect, nxp, telink)
Decreases (22 builds for bl602, bl702, bl702l, cc32xx, efr32, linux, nxp)
Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, stm32, telink)
|
PR #33646: Size comparison from 7ebc71f to 6b94ffc Increases (19 builds for nrfconnect, telink)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Jun 1, 2024
tcarmelveilleux
approved these changes
Jun 3, 2024
69883dc
to
5b20da0
Compare
PR #33646: Size comparison from 8a64366 to 5b20da0 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
reviewed
Jun 3, 2024
Currently it's only possible to allocate fabric indexes sequentially starting from 1. Sparse fabric tables could be produced by adding & removing fabrics, but not directly. This allow the application to control the assignment of fabric ids directly by providing a function that overrides the next index to use. eg If an application has 3 fabrics, it can recreate the fabric table from scratch while keeping consistent indexes.
5b20da0
to
15487b8
Compare
PR #33646: Size comparison from 8a64366 to 15487b8 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's only possible to allocate fabric indexes sequentially starting from 1.
Sparse fabric tables could be produced by adding & removing fabrics, but not directly.
This allow the application to control the assignment of fabric ids directly by providing a function that overrides the next index to use.
eg If an application has 3 fabrics, it can recreate the fabric table from scratch while keeping consistent indexes.