Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Add basic support for reporting application installation status #33655

Closed
wants to merge 2 commits into from
Closed

Restyle Add basic support for reporting application installation status #33655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd272ef
Restyled by whitespace
restyled-commits May 29, 2024
2be286f
Restyled by clang-format
restyled-commits May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/tv-app/tv-common/src/AppTv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,8 @@ bool ContentAppFactoryImpl::UninstallContentApp(uint16_t vendorId, uint16_t prod
return false;
}

std::string createSearchIndex(uint16_t vendorId, uint16_t productId) {
std::string createSearchIndex(uint16_t vendorId, uint16_t productId)
{
// Format the IDs into a string
std::string formattedString = std::to_string(vendorId) + ":" + std::to_string(productId);
return formattedString;
Expand Down
3 changes: 1 addition & 2 deletions src/controller/CommissionerDiscoveryController.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,7 @@ void CommissionerDiscoveryController::InternalOk()
// notify client the current app's installation status
CommissionerDeclaration cd;
cd.SetErrorCode(appInstallStatus);
mUdcServer->SendCDCMessage(cd,
Transport::PeerAddress::UDP(client->GetPeerAddress().GetIPAddress(), client->GetCdPort()));
mUdcServer->SendCDCMessage(cd, Transport::PeerAddress::UDP(client->GetPeerAddress().GetIPAddress(), client->GetCdPort()));
return;
}

Expand Down
4 changes: 2 additions & 2 deletions src/controller/CommissionerDiscoveryController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,8 @@ class DLL_EXPORT AppInstallationService
/**
* @brief
* Called to check app's installation status.
*
* CdError status is designed for CommissionerDeclaration and should be set by using SetErrorCode() and
*
* CdError status is designed for CommissionerDeclaration and should be set by using SetErrorCode() and
* sent back to the client as a CDC Message. It is expected that app installation can have following statuses:
* kNoError, kAppInstallConsentPending, kAppInstalling, kAppInstallFailed, kAppInstalledRetryNeeded
*
Expand Down