Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thread] add Thread stack lock held for output the unicast addresses #33661

Merged
merged 3 commits into from
Jun 3, 2024
Merged

[thread] add Thread stack lock held for output the unicast addresses #33661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a100b5e
[thread] add Thread stack lock held for output the unicast addresses
ZhangLe2016 May 29, 2024
1250b93
[thread] add Thread stack lock held for output the unicast addresses
ZhangLe2016 May 29, 2024
ec99887
Merge branch 'crash-mitigatation' of github.com:ZhangLe2016/connected…
ZhangLe2016 May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,9 @@ void GenericThreadStackManagerImpl_OpenThread<ImplClass>::_OnPlatformEvent(const
}

#if CHIP_DETAIL_LOGGING
Impl()->LockThreadStack();
LogOpenThreadStateChange(mOTInst, event->ThreadStateChange.OpenThread.Flags);
Impl()->UnlockThreadStack();
#endif // CHIP_DETAIL_LOGGING
}
}
Expand Down
5 changes: 0 additions & 5 deletions src/platform/OpenThread/OpenThreadUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,6 @@ void RegisterOpenThreadErrorFormatter(void)
RegisterErrorFormatter(&sOpenThreadErrorFormatter);
}

/**
* Log information related to a state change in the OpenThread stack.
*
* NB: This function *must* be called with the Thread stack lock held.
*/
void LogOpenThreadStateChange(otInstance * otInst, uint32_t flags)
{
#if CHIP_DETAIL_LOGGING
Expand Down
6 changes: 6 additions & 0 deletions src/platform/OpenThread/OpenThreadUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ namespace Internal {

extern CHIP_ERROR MapOpenThreadError(otError otErr);
extern void RegisterOpenThreadErrorFormatter(void);

/**
* Log information related to a state change in the OpenThread stack.
*
* NB: This function *must* be called with the Thread stack lock held.
*/
extern void LogOpenThreadStateChange(otInstance * otInst, uint32_t flags);
extern void LogOpenThreadPacket(const char * titleStr, otMessage * pkt);
extern bool IsOpenThreadMeshLocalAddress(otInstance * otInst, const Inet::IPAddress & addr);
Expand Down
Loading