Update energy management clusters xml for 1.4 #33673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xml using Alchemy and spec commit: dbf7c6dd7206fa4a4647f8a6218325fbe6c8ec6c Note more DEM PRs are yet to merge.
|
PR #33673: Size comparison from 1f1b750 to 1b9021e Full report (2 builds for mbed, stm32)
|
|
PR #33673: Size comparison from 1f1b750 to c508af5 Increases (7 builds for cc13x4_26x4, nxp)
Decreases (13 builds for bl602, bl702, bl702l, cc32xx, efr32)
Full report (26 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, mbed, nxp, stm32)
|
|
PR #33673: Size comparison from 1f1b750 to f34083f Decreases (2 builds for cc32xx)
Full report (4 builds for cc32xx, mbed, stm32)
|
|
PR #33673: Size comparison from 1f1b750 to 824f90b Increases (7 builds for cc13x4_26x4, nxp)
Decreases (13 builds for bl602, bl702, bl702l, cc32xx, efr32)
Full report (26 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, mbed, nxp, stm32)
|
…neration of a top-level list in the PowerAdjustmentCapability attribute.
…ich causes ZAP to complain about more than 2 byte length.
…ustementCapability list moving one level below.
|
PR #33673: Size comparison from ab2907b to 9bd8e16 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…s when running zap_regen_all.py. Also used Alchemy --featureXML.
github-actions
bot
added
the
documentation
|
PR #33673: Size comparison from b194ca5 to f8b35c2 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/app/zap-templates/zcl/data-model/chip/energy-evse-cluster.xml
Outdated
Show resolved
Hide resolved
|
PR #33673: Size comparison from 58536ba to dec0b2e Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33673: Size comparison from 58536ba to 3fbdfec Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
… fields in ChargingTargetScheduleStruct + regen zap files
|
PR #33673: Size comparison from 58536ba to e43ff1e Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 3, 2024
src/app/zap-templates/zcl/data-model/chip/energy-evse-cluster.xml
Outdated
Show resolved
Hide resolved
andy31415
added
the
skip-protocol-compatibility
|
PR #33673: Size comparison from 70744ed to 88a1ba1 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
… on review that DischargingCurrent was inconsistent.
|
PR #33673: Size comparison from 8786012 to e9a80de Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jul 9, 2024
lazarkov
pushed a commit
to lazarkov/connectedhomeip
that referenced
this pull request
Jul 10, 2024
* Updated device-energy-management-cluster.xml and energy-evse-cluster.xml using Alchemy and spec commit: dbf7c6dd7206fa4a4647f8a6218325fbe6c8ec6c Note more DEM PRs are yet to merge. * Regen_all checked in. * Added missing energy-management-app.matter * Updated with spec PR project-chip#9251 merged to master. * Updated with spec PR project-chip#9266 (change ForecastId -> ForecastID) * regen_all * Removed extra entryType="PowerAdjustStruct" which causes incorrect generation of a top-level list in the PowerAdjustmentCapability attribute. * Removed extra min="-4611686018427387904" max="4611686018427387903" which causes ZAP to complain about more than 2 byte length. * Updated after regen_all * Reverted max="86400" in RANDOMIZATION_DELAY_WINDOW which upsets some builds * Added missing autogen'd code for DEM changes. * Fix up compilation errors caused by change to forecastID and powerAdjustementCapability list moving one level below. * Added Water Heater Management cluster XML * Added Water Heater Management to controller-clusters.zap * Added Water Heater Management to zap_cluster_list.json * Added Water Heater Management cluster to all-clusters-app.zap * Tried to add apiMaturity="provisional" to silence deprecation warnings when running zap_regen_all.py. Also used Alchemy --featureXML. * Added all-clusters-app.matter and controller-clusters.matter after regen_all * Added output from regen_all.py * Updated .zap files after adding provisional flag. * Added Java matter controller now that apiMaturity=provisional has popped out. * Trying to remove Thread Border Router Management in controller-clusters.zap as a test. * Removed water-heater-management-server for now so compilers don't try to compile it. * Reverted all-clusters-app.zap (removed Water heater). Reverted controller-clusters.zap (put back Thread Border Router, removed Water Heater) * updated all-clusters-app.matter after removing WaterHeaterManagement cluster (to avoid compile failures). * Candidate fix for THREAD_BORDER_ROUTER_MANAGEMENT_CLUSTER which resolves the error. [Should be a duplicate of PR project-chip#34000 when that merges. * Addressing review comments from Boris * Regenerate files * Regenerate files correctly * Removal optional conformance fro DayOfWeekForSequence/ChargingTargets fields in ChargingTargetScheduleStruct + regen zap files * Updated energy-evse-cluster using Alchemy to match Spec PR:9317 based on review that DischargingCurrent was inconsistent. * Updated after regen_all --------- Co-authored-by: pcoleman <pcoleman@geotogether.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
* Updated device-energy-management-cluster.xml and energy-evse-cluster.xml using Alchemy and spec commit: dbf7c6dd7206fa4a4647f8a6218325fbe6c8ec6c Note more DEM PRs are yet to merge. * Regen_all checked in. * Added missing energy-management-app.matter * Updated with spec PR project-chip#9251 merged to master. * Updated with spec PR project-chip#9266 (change ForecastId -> ForecastID) * regen_all * Removed extra entryType="PowerAdjustStruct" which causes incorrect generation of a top-level list in the PowerAdjustmentCapability attribute. * Removed extra min="-4611686018427387904" max="4611686018427387903" which causes ZAP to complain about more than 2 byte length. * Updated after regen_all * Reverted max="86400" in RANDOMIZATION_DELAY_WINDOW which upsets some builds * Added missing autogen'd code for DEM changes. * Fix up compilation errors caused by change to forecastID and powerAdjustementCapability list moving one level below. * Added Water Heater Management cluster XML * Added Water Heater Management to controller-clusters.zap * Added Water Heater Management to zap_cluster_list.json * Added Water Heater Management cluster to all-clusters-app.zap * Tried to add apiMaturity="provisional" to silence deprecation warnings when running zap_regen_all.py. Also used Alchemy --featureXML. * Added all-clusters-app.matter and controller-clusters.matter after regen_all * Added output from regen_all.py * Updated .zap files after adding provisional flag. * Added Java matter controller now that apiMaturity=provisional has popped out. * Trying to remove Thread Border Router Management in controller-clusters.zap as a test. * Removed water-heater-management-server for now so compilers don't try to compile it. * Reverted all-clusters-app.zap (removed Water heater). Reverted controller-clusters.zap (put back Thread Border Router, removed Water Heater) * updated all-clusters-app.matter after removing WaterHeaterManagement cluster (to avoid compile failures). * Candidate fix for THREAD_BORDER_ROUTER_MANAGEMENT_CLUSTER which resolves the error. [Should be a duplicate of PR project-chip#34000 when that merges. * Addressing review comments from Boris * Regenerate files * Regenerate files correctly * Removal optional conformance fro DayOfWeekForSequence/ChargingTargets fields in ChargingTargetScheduleStruct + regen zap files * Updated energy-evse-cluster using Alchemy to match Spec PR:9317 based on review that DischargingCurrent was inconsistent. * Updated after regen_all --------- Co-authored-by: pcoleman <pcoleman@geotogether.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 18, 2024
* Updated device-energy-management-cluster.xml and energy-evse-cluster.xml using Alchemy and spec commit: dbf7c6dd7206fa4a4647f8a6218325fbe6c8ec6c Note more DEM PRs are yet to merge. * Regen_all checked in. * Added missing energy-management-app.matter * Updated with spec PR project-chip#9251 merged to master. * Updated with spec PR project-chip#9266 (change ForecastId -> ForecastID) * regen_all * Removed extra entryType="PowerAdjustStruct" which causes incorrect generation of a top-level list in the PowerAdjustmentCapability attribute. * Removed extra min="-4611686018427387904" max="4611686018427387903" which causes ZAP to complain about more than 2 byte length. * Updated after regen_all * Reverted max="86400" in RANDOMIZATION_DELAY_WINDOW which upsets some builds * Added missing autogen'd code for DEM changes. * Fix up compilation errors caused by change to forecastID and powerAdjustementCapability list moving one level below. * Added Water Heater Management cluster XML * Added Water Heater Management to controller-clusters.zap * Added Water Heater Management to zap_cluster_list.json * Added Water Heater Management cluster to all-clusters-app.zap * Tried to add apiMaturity="provisional" to silence deprecation warnings when running zap_regen_all.py. Also used Alchemy --featureXML. * Added all-clusters-app.matter and controller-clusters.matter after regen_all * Added output from regen_all.py * Updated .zap files after adding provisional flag. * Added Java matter controller now that apiMaturity=provisional has popped out. * Trying to remove Thread Border Router Management in controller-clusters.zap as a test. * Removed water-heater-management-server for now so compilers don't try to compile it. * Reverted all-clusters-app.zap (removed Water heater). Reverted controller-clusters.zap (put back Thread Border Router, removed Water Heater) * updated all-clusters-app.matter after removing WaterHeaterManagement cluster (to avoid compile failures). * Candidate fix for THREAD_BORDER_ROUTER_MANAGEMENT_CLUSTER which resolves the error. [Should be a duplicate of PR project-chip#34000 when that merges. * Addressing review comments from Boris * Regenerate files * Regenerate files correctly * Removal optional conformance fro DayOfWeekForSequence/ChargingTargets fields in ChargingTargetScheduleStruct + regen zap files * Updated energy-evse-cluster using Alchemy to match Spec PR:9317 based on review that DischargingCurrent was inconsistent. * Updated after regen_all --------- Co-authored-by: pcoleman <pcoleman@geotogether.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerated XML files using Alchemy tool
Update EnergyEVSE cluster (these changes should be backwards compatible since the structural changes are only on provisional features, or adding to an existing structure). I have not disabled that checker so that other people can confirm this is true.
For review:
2024-06-18 19:06:17 ERROR Struct EnergyEvse::ChargingTargetScheduleStruct has field changesthis is in the PREFs feature which was not part of SVE in 1.3
2024-06-18 19:06:17 ERROR Event EnergyEvse::EnergyTransferStarted has field changesthis change adds a new field (maximumDischargingCurrent) for V2X feature which is Provisional in 1.4
2024-06-18 19:06:17 ERROR Event EnergyEvse::EnergyTransferStopped has field changesthis change adds a new field (energyDischarged) for V2X feature which is Provisional in 1.4
Added WaterHeaterManagement cluster XML only
[Note this is based on Spec PR: #9311 which is ready to merge]
Fixes Add WaterHeater Management XML #34251