-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark AutoRelockTime attribute of the Door Lock cluster as optional in the XML #33701
Mark AutoRelockTime attribute of the Door Lock cluster as optional in the XML #33701
Conversation
PR #33701: Size comparison from 294dc18 to 46810a7 Decreases (3 builds for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33701: Size comparison from 046fd51 to 793bb97 Decreases (3 builds for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
So this is not doing a "sync" with the spec like the PR subject says, it's just marking the one attribute as optional? |
793bb97
to
bf534dc
Compare
PR #33701: Size comparison from ca33a40 to bf534dc Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bf534dc
to
d1b29ac
Compare
PR #33701: Size comparison from 321f895 to d1b29ac Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
@Thirsrin this is a backwards-incompatible change (API change). may need a bit more review if/why this would be safe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking this as hold a bit, until we are able to discuss (likely offline from this PR) about sideffects of API changes.
What we wish we had is full API stability, however in practice this is hard if the spec says one thing and the SDK implements something else.
Looking to figure out what to do here.
d1b29ac
to
4ca97a1
Compare
PR #33701: Size comparison from c158260 to 4ca97a1 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Dismissing: spec is fixed, so since this does not break over the wire compatibility in most cases (just assumptions that may exist) we can allow it through.
PR #33701: Size comparison from 540c991 to 276bb37 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Description:
AutoRelockTime attribute is optional attribute for doorlock cluster(doorlock.xml) as per matter specs(sec 5.2.9).