pw_unit_test migration: apps-2 #33734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alami-Amine
changed the title
|
PR #33734: Size comparison from d8e7e43 to d2336f3 Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nxp, psoc6, qpg, stm32, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
|
PR #33734: Size comparison from d8e7e43 to 36495c1 Full report (6 builds for cc32xx, mbed, stm32, tizen)
|
|
PR #33734: Size comparison from d8e7e43 to 423566c Full report (29 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, mbed, nxp, qpg, stm32, tizen)
|
andy31415
approved these changes
Jun 4, 2024
|
PR #33734: Size comparison from ef28056 to 4c6e1b7 Full report (5 builds for cc32xx, qpg, stm32)
|
|
PR #33734: Size comparison from ef28056 to d980852 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33734: Size comparison from 0050994 to f01f040 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33734: Size comparison from 6092e8a to db773ea Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/apptests (related to Interaction Model) first started in pw_unit_test migration: apps-1 and stub-refactoring #33638In this PR:
*TestAccessclasses to allow tests to access private class members*TestAccessclasses asfriendto the classes they need access to.FRIEND_TESTapi which needs to be applied to EVERY testcase that needs access to a private class member.- UPDATE: It was decided to not use
*TestAccess.hclasses as they overcomplicate the testscript, instead, I re-used the MacroTEST_F_FROM_FIXTUREfrom ExtraPwTestMacros.h and created a new PR : #33772