Fix download log test #33788
Open
Fix download log test #33788
+24
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivi-apple
force-pushed
the
fix_download_log_test
branch
from
a0da6e2 to
2c427ca
Compare
|
PR #33788: Size comparison from a2a25fb to 137aee4 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33788: Size comparison from a2a25fb to ebf65fc Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
nivi-apple
force-pushed
the
fix_download_log_test
branch
from
ebf65fc to
5a97300
Compare
|
PR #33788: Size comparison from 3d7e23e to fc69249 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve and
harimau-qirex
pullapprove
bot
requested review from
mkardous-silabs,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #33788: Size comparison from 3d7e23e to 7c28d9c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| } | ||
|
|
||
| void BDXDiagnosticLogsProvider::OnTimeout() | ||
| { | ||
| ChipLogError(BDX, "Timeout"); | ||
| VerifyOrDo(mIsAcceptReceived, SendCommandResponse(StatusEnum::kDenied)); | ||
| Reset(); | ||
| mTransfer.AbortTransfer(GetBdxStatusCodeFromChipError(CHIP_ERROR_TIMEOUT)); |
There was a problem hiding this comment.
How does the transfer get reset after this point (and similarly in OnInternalError)? My understanding is AbortTransfer will trigger a status report to be sent and then the exchange will close since no response is expected for the status report. I don't think this class calls Reset when handling those (through OnMsgToSend or OnExchangeClosing), so would the rest of the internal state still be set?
There was a problem hiding this comment.
Yeah I guess you are right. I looked at BDX a long time ago. From what I remember for OTA we abort transfer and then waited sometime for the status report to go through and called Reset from what I recall. We could something similar. That being said I am not sure if the test is failing due to a genuine issue or merely not cleaning up after finishing the tests and overlaps the next test. I am looking at that now. will update the PR accordingly
nivi-apple
force-pushed
the
fix_download_log_test
branch
from
7c28d9c to
423824e
Compare
|
PR #33788: Size comparison from c1a6391 to 423824e Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…twork Diagnostic log intent" to make sure the test completes. - Add a check for Diagnostic logs status report message after test - "Read Network Diagnostic log intent with a very short timeout and a very long log" to make sure the test is complete.
woody-apple
force-pushed
the
fix_download_log_test
branch
from
423824e to
29e3fab
Compare
|
PR #33788: Size comparison from c05110f to 29e3fab Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the download log test that expects a failure by waiting for the status report before continuing to the next test
Fixes: #32636