Read base path for config files from TMPDIR env var #33846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PR #33846: Size comparison from bd0422b to 76750ee Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
locnnil
reviewed
Jun 11, 2024
jpm-canonical
force-pushed
the
feature/linux-config-path-env-var
branch
from
76750ee to
1e73d53
Compare
|
PR #33846: Size comparison from dc8187b to 1e73d53 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jpm-canonical
force-pushed
the
feature/linux-config-path-env-var
branch
from
1e73d53 to
b460245
Compare
|
PR #33846: Size comparison from e1d746a to b460245 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jpm-canonical
force-pushed
the
feature/linux-config-path-env-var
branch
from
b460245 to
76e4435
Compare
|
PR #33846: Size comparison from f6ac926 to 76e4435 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic and
dhrishi
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #33846: Size comparison from 38f664f to c81b16e Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33846: Size comparison from ee49ebd to 0bd8b13 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30790
Change hard coded paths for
chip_factory.ini,chip_config.iniandchip_counters.inito rather use existingTMPDIRenvironment variable.Before this change these files are stored under
/tmp/*. After the change they are stored under$TMPDIR/*, with a fallback to/tmp/*if the variable is not set.Rationale
Chip Tool might be used by different users on a system. If the paths are set at build time, multiple users will use the same storage file. This causes a permission error. The first user that runs Chip Tool will be the owner of the files, and the only user that can read and write the files. Subsequent users will see Chip Tool failing with a permission error on these files.
By allowing to override the path for storage file with an environment variable, one can set different paths for different users. This allows isolating different users' storage files, and prevents permission errors on these files.