-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fabric Bridge] Overwrite the default implementation of Administrator Commissioning C… #33909
Merged
mergify
merged 2 commits into
project-chip:master
from
yufengwangca:pr/fabric_bridge/admin
Jun 18, 2024
Merged
[Fabric Bridge] Overwrite the default implementation of Administrator Commissioning C… #33909
mergify
merged 2 commits into
project-chip:master
from
yufengwangca:pr/fabric_bridge/admin
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33909: Size comparison from b05165e to ce3c93e Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #33909: Size comparison from fab01d8 to 8fb36d0 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
reviewed
Jun 17, 2024
PR #33909: Size comparison from 8ba371a to 95e801d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
approved these changes
Jun 18, 2024
jmartinez-silabs
approved these changes
Jun 18, 2024
diogopintodsr
pushed a commit
to diogopintodsr/connectedhomeip
that referenced
this pull request
Jun 20, 2024
… Commissioning C… (project-chip#33909) * Overwrite the default implementation of Administrator Commissioning Cluster * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each Bridged Node contains Administrator Commissioning Cluster, we need to overwrite the default implementation (https://github.com/project-chip/connectedhomeip/blob/master/src/app/clusters/admin[…]tor-commissioning-server/administrator-commissioning-server.cpp) in the Bridged Node endpoint, such as we it receive OCW command, instead of default operations, it needs to notify the Fabric Admin to open the commissioning window
Fixes #33764