Add Meter Identification cluster #33922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PR #33922: Size comparison from 60ae46d to 2d79803 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jun 14, 2024
| @@ -0,0 +1,135 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
How was this added? data_model files are managed by a script and should be included only as part of script execution (i.e. from parsing asciidoc files)
There was a problem hiding this comment.
In the image and likeness of other clusters
Michail-Antropov
force-pushed
the
meter_identification
branch
2 times, most recently
from
05e8621 to
a9463dd
Compare
|
PR #33922: Size comparison from 6842912 to a9463dd Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Jun 15, 2024
There was a problem hiding this comment.
Please split this into separate PRs for:
- Add the cluster XML (needs careful review by a set of people)
- Add the cluster implementation (needs careful review by a slightly different set of people)
- Add the example app bits.
| @@ -0,0 +1,57 @@ | |||
| <?xml version="1.0"?> | |||
| <!-- | |||
| Copyright (c) 2023 Project CHIP Authors | |||
There was a problem hiding this comment.
This does not look like the right year.
There was a problem hiding this comment.
I don't see this cluster in the spec, by the way, which makes reviewing this impossible.
Michail-Antropov
force-pushed
the
meter_identification
branch
from
a9463dd to
abbe8ab
Compare
|
PR #33922: Size comparison from 667cae8 to abbe8ab Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Fix XML errors
|
PR #33922: Size comparison from 667cae8 to 6729164 Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
|
PR #33922: Size comparison from 667cae8 to f79c1e1 Increases above 0.2%:
Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
|
PR #33922: Size comparison from 667cae8 to b53abf5 Increases above 0.2%:
Full report (16 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
Michail-Antropov
force-pushed
the
meter_identification
branch
from
b53abf5 to
b663c8e
Compare
|
PR #33922: Size comparison from 667cae8 to b663c8e Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
github-actions
bot
added
documentation
|
PR #33922: Size comparison from 667cae8 to bf1ae81 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Split to 3 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress