Removing NL Unit Infrastructure #33943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #33943: Size comparison from 8b905ab to 2d9f741 Full report (96 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33943: Size comparison from 4d5e2ee to 6710551 Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nxp, psoc6, qpg, stm32, tizen)
|
github-actions
bot
added
scripts
transport
setup payload
lib
inet
app
gn
tests
support
icd
Alami-Amine
changed the title
|
PR #33943: Size comparison from 4d5e2ee to 6475996 Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple and
arkq
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
andy31415
reviewed
Jun 17, 2024
andy31415
approved these changes
Jun 17, 2024
|
PR #33943: Size comparison from 4d5e2ee to ef22d3a Full report (96 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
reviewed
Jun 17, 2024
arkq
approved these changes
Jun 18, 2024
|
PR #33943: Size comparison from 4cdce52 to a77a5ec Full report (96 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
diogopintodsr
pushed a commit
to diogopintodsr/connectedhomeip
that referenced
this pull request
Jun 20, 2024
* removing nl_unit infra from ESP32 * removing nl_unit infra from Nordic * removing nl_unit infra from OpenIoTSDK * removing nl_unit infra from mbed * removing nl_unit infra from EFR32 * removing include dependencies of nl_unit_test * making Mbed Unit Tests return an Error to clarify that they are disabled * adding issue number to code comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since nl_unit_tests are now deprecated and all tests converted to pw_unit_test,
nl_unitdependencies will be removed from the stack.pw_unit conversion was first discussed in: Testing using pw_unit_test #29342
In This PR
removing
nl_unitinfrastructure from:nl_unit_testsare being removed.all
#includerelated to nl_unit_testscleaning
nl_unitreferences in GN build filesdeleting
nl_unitrelated files and scripts such asscripts/gen_test_driver.py