[Draft] Re-Implement App Install flow #33982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #33982: Size comparison from 4cdce52 to 112656e Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33982: Size comparison from ab2907b to 456adc1 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| @@ -225,6 +225,7 @@ CHIP_ERROR ApplicationBasicAttrAccess::ReadApplicationAttribute(app::AttributeVa | |||
|
|
|||
| CHIP_ERROR ApplicationBasicAttrAccess::ReadStatusAttribute(app::AttributeValueEncoder & aEncoder, Delegate * delegate) | |||
| { | |||
| ChipLogProgress(DeviceLayer, "Here 1"); | |||
There was a problem hiding this comment.
This is not a useful log.
Comment on lines
+54
to
+57
| <item name="NotInstalled" value="0x04"/> | ||
| <item name="Installing" value="0x05"/> | ||
| <item name="InstallationFailed" value="0x06"/> | ||
| <item name="Installed" value="0x07"/> |
There was a problem hiding this comment.
I don't see these in the spec. Why are we adding random non-spec bits here?
|
PR #33982: Size comparison from 9d56786 to 98235b2 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33982: Size comparison from 7c04979 to 694132b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-Implementing application installation flow. Continuation of #33959
Problem
Current application installation flow blocks commissioning and has too crude functionality that cannot provide great UX (providing installation percentage etc.)
Change overview
Tests
Build the TV app using command:
scripts/examples/gn_build_example.sh examples/tv-app/linux out/debug/Build the TV casting app using command:
scripts/examples/gn_build_example.sh examples/tv-casting-app/linux out/debug/Start TV App
out/debug/chip-tv-appStart TV Casting App
out/debug/chip-tv-casting-appSend Application Launcher command
cast cluster applicationlauncher launch-app 0 1 --Application {"catalogVendorID":123,"applicationID":"com.example.contentapp"}You should receive pending state:
{ status: 3, data: "" }Start the app install of content app and send application launcher command again
You should receive installing state:
{ status: 4, data: "" }In case app install failed and you send application launcher command, you should then receive the state:
{ status: 3, data: "App install failed. Try again" }---------- TBA --------
Need to add support for tv linux