Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Re-Implement App Install flow #33982

Conversation

lazarkov
Copy link
Contributor

@lazarkov lazarkov commented Jun 18, 2024

Re-Implementing application installation flow. Continuation of #33959

Problem

Current application installation flow blocks commissioning and has too crude functionality that cannot provide great UX (providing installation percentage etc.)

Change overview

  • Updated pre-commissioning part of app install flow and removed blocking of commissioning if app is not installed
  • Add app when it is not installed
  • Extend application basic cluster with: installed, not installed, installation failed and installation completed

Tests

  1. Build the TV app using command:
    scripts/examples/gn_build_example.sh examples/tv-app/linux out/debug/

  2. Build the TV casting app using command:
    scripts/examples/gn_build_example.sh examples/tv-casting-app/linux out/debug/

  3. Start TV App
    out/debug/chip-tv-app

  4. Start TV Casting App
    out/debug/chip-tv-casting-app

  5. Send Application Launcher command
    cast cluster applicationlauncher launch-app 0 1 --Application {"catalogVendorID":123,"applicationID":"com.example.contentapp"}

You should receive pending state:
{ status: 3, data: "" }

  1. Start the app install of content app and send application launcher command again
    You should receive installing state:
    { status: 4, data: "" }

  2. In case app install failed and you send application launcher command, you should then receive the state:
    { status: 3, data: "App install failed. Try again" }

---------- TBA --------
Need to add support for tv linux

Copy link

github-actions bot commented Jun 18, 2024

PR #33982: Size comparison from 4cdce52 to 112656e

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 4cdce52 112656e change % change
bl602 lighting-app bl602 FLASH 1270530 1270530 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284808 1284808 0 0.0
RAM 95480 95480 0 0.0
bl602+rpc FLASH 1309730 1309730 0 0.0
RAM 103760 103760 0 0.0
bl702 lighting-app bl702 FLASH 1091426 1091426 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1102120 1102120 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1181236 1181236 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 874770 874770 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1127064 1127064 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1078312 1078312 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1089574 1089574 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798076 798076 0 0.0
RAM 103088 103088 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813752 813752 0 0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803268 803268 0 0.0
RAM 107688 107688 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756060 756060 0 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741724 741724 0 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605750 605750 0 0.0
RAM 204512 204512 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650770 650770 0 0.0
RAM 204772 204772 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661673 661673 0 0.0
RAM 74512 74512 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681517 681517 0 0.0
RAM 77144 77144 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681517 681517 0 0.0
RAM 77144 77144 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638453 638453 0 0.0
RAM 69580 69580 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 604137 604137 0 0.0
RAM 70216 70216 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623773 623773 0 0.0
RAM 72768 72768 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623773 623773 0 0.0
RAM 72768 72768 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619641 619641 0 0.0
RAM 73232 73232 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639357 639357 0 0.0
RAM 75784 75784 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639357 639357 0 0.0
RAM 75784 75784 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 588213 588213 0 0.0
RAM 67200 67200 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 608073 608073 0 0.0
RAM 69832 69832 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 608073 608073 0 0.0
RAM 69832 69832 0 0.0
efr32 lighting-app BRD4187C FLASH 888232 888224 -8 -0.0
RAM 183424 183424 0 0.0
lock-app BRD4338a FLASH 699848 699848 0 0.0
RAM 242228 242228 0 0.0
window-app BRD4187C FLASH 969748 969748 0 0.0
RAM 167856 167856 0 0.0
esp32 all-clusters-app c3devkit DRAM 88324 88324 0 0.0
FLASH 1468918 1468918 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1538067 1538067 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4568 4568 0 0.0
FLASH 2535024 2535024 0 0.0
RAM 129072 129072 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5581550 5581614 64 0.0
RAM 483272 483400 128 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5054984 5055032 48 0.0
RAM 236824 236824 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4480632 4480632 0 0.0
RAM 216736 216736 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11527527 11527591 64 0.0
RAM 535450 535578 128 0.0
chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10663892 10663956 64 0.0
RAM 583416 583544 128 0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 10526455 1052648 32 0.0
RAM 529466 529594 128 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4350568 4350568 0 0.0
RAM 208784 208784 0 0.0
lighting-app debug+rpc+ui unknown 5880 5880 0 0.0
FLASH 5377746 5377746 0 0.0
RAM 225640 225640 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4544296 4544296 0 0.0
RAM 204192 204192 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4180008 4180008 0 0.0
RAM 193216 193216 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4305496 4305496 0 0.0
RAM 197872 197872 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2801965 2801965 0 0.0
RAM 154416 154416 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4152804 4152804 0 0.0
RAM 234608 234608 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5597304 5599896 2592 0.0
RAM 345672 345672 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9572774 9572774 0 0.0
RAM 352816 352816 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497580 1497580 0 0.0
RAM 226072 226072 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 876200 876200 0 0.0
RAM 139129 139129 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 949232 949232 0 0.0
RAM 137557 137557 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 822416 822440 24 0.0
RAM 138027 138027 0 0.0
nxp contact k32w0+release FLASH 575604 575604 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590736 590736 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609680 609680 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674224 674224 0 0.0
RAM 82808 82808 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613428 1613428 0 0.0
RAM 207132 207132 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534228 1534252 24 0.0
RAM 204036 204036 0 0.0
light cy8ckit_062s2_43012 FLASH 1461092 1461092 0 0.0
RAM 197316 197316 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462844 1462844 0 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 650576 650576 0 0.0
RAM 104556 104556 0 0.0
lock-app qpg6105+debug FLASH 610700 610700 0 0.0
RAM 99232 99232 0 0.0
stm32 light STM32WB5MM-DK FLASH 472112 472112 0 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625532 625532 0 0.0
RAM 49904 49904 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 602572 602572 0 0.0
RAM 130288 130288 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770694 770730 36 0.0
RAM 110052 110052 0 0.0
bridge-app tlsr9258a FLASH 668618 668618 0 0.0
RAM 94672 94672 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 627254 627254 0 0.0
RAM 49948 49948 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713368 713368 0 0.0
RAM 76540 76540 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 558240 558240 0 0.0
RAM 126544 126544 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793320 793320 0 0.0
RAM 99900 99900 0 0.0
lock-app-dfu tlsr9528a FLASH 660356 660356 0 0.0
RAM 69228 69228 0 0.0
ota-requestor-app tlsr9258a FLASH 687236 687236 0 0.0
RAM 94396 94396 0 0.0
pump-app tlsr9518adk80d FLASH 609474 609474 0 0.0
RAM 56328 56328 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599860 599860 0 0.0
RAM 56128 56128 0 0.0
shell tlsr9518adk80d FLASH 462614 462614 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633616 633616 0 0.0
RAM 51576 51576 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642974 642974 0 0.0
RAM 59764 59764 0 0.0
thermostat tlsr9518adk80d FLASH 618750 618750 0 0.0
RAM 56452 56452 0 0.0
window-covering tlsr9118bdk40d FLASH 464942 464942 0 0.0
RAM 82224 82224 0 0.0
tizen all-clusters-app arm unknown 1548 1548 0 0.0
FLASH 1621556 1621556 0 0.0
RAM 45420 45420 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15767058 15767210 152 0.0
RAM 6917600 6917600 0 0.0

@lazarkov lazarkov self-assigned this Jun 18, 2024
Copy link

github-actions bot commented Jun 18, 2024

PR #33982: Size comparison from ab2907b to 456adc1

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section ab2907b 456adc1 change % change
bl602 lighting-app bl602 FLASH 1270530 1270530 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284808 1284808 0 0.0
RAM 95480 95480 0 0.0
bl602+rpc FLASH 1309730 1309730 0 0.0
RAM 103760 103760 0 0.0
bl702 lighting-app bl702 FLASH 1091426 1091426 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1102120 1102120 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1181236 1181236 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 874770 874770 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1127064 1127064 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1078312 1078312 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1089574 1089574 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798076 798076 0 0.0
RAM 103088 103088 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813752 813752 0 0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803268 803268 0 0.0
RAM 107688 107688 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756060 756060 0 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741724 741724 0 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605750 605750 0 0.0
RAM 204512 204512 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650770 650770 0 0.0
RAM 204772 204772 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661673 661673 0 0.0
RAM 74512 74512 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681517 681517 0 0.0
RAM 77144 77144 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681517 681517 0 0.0
RAM 77144 77144 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638453 638453 0 0.0
RAM 69580 69580 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 604137 604137 0 0.0
RAM 70216 70216 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623773 623773 0 0.0
RAM 72768 72768 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623773 623773 0 0.0
RAM 72768 72768 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619641 619641 0 0.0
RAM 73232 73232 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639357 639357 0 0.0
RAM 75784 75784 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639357 639357 0 0.0
RAM 75784 75784 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 588213 588213 0 0.0
RAM 67200 67200 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 608073 608073 0 0.0
RAM 69832 69832 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 608073 608073 0 0.0
RAM 69832 69832 0 0.0
efr32 lighting-app BRD4187C FLASH 888232 888224 -8 -0.0
RAM 183424 183424 0 0.0
lock-app BRD4338a FLASH 699848 699848 0 0.0
RAM 242228 242228 0 0.0
window-app BRD4187C FLASH 969748 969748 0 0.0
RAM 167856 167856 0 0.0
esp32 all-clusters-app c3devkit DRAM 88324 88324 0 0.0
FLASH 1468918 1468918 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1538067 1538067 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4568 4568 0 0.0
FLASH 2535024 2535024 0 0.0
RAM 129072 129072 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5581550 5581614 64 0.0
RAM 483272 483400 128 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5054984 5055032 48 0.0
RAM 236824 236824 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4480632 4480632 0 0.0
RAM 216736 216736 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11527527 11527591 64 0.0
RAM 535450 535578 128 0.0
chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10663892 10663956 64 0.0
RAM 583416 583544 128 0.0
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 10526455 1052648 32 0.0
RAM 529466 529594 128 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4350568 4350568 0 0.0
RAM 208784 208784 0 0.0
lighting-app debug+rpc+ui unknown 5880 5880 0 0.0
FLASH 5377746 5377746 0 0.0
RAM 225640 225640 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4544296 4544296 0 0.0
RAM 204192 204192 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4180008 4180008 0 0.0
RAM 193216 193216 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4305496 4305496 0 0.0
RAM 197872 197872 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2801965 2801965 0 0.0
RAM 154416 154416 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4152804 4152804 0 0.0
RAM 234608 234608 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5597304 5599896 2592 0.0
RAM 345672 345672 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9572774 9572774 0 0.0
RAM 352816 352816 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497580 1497580 0 0.0
RAM 226072 226072 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 876200 876200 0 0.0
RAM 139129 139129 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 949232 949232 0 0.0
RAM 137557 137557 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 822416 822440 24 0.0
RAM 138027 138027 0 0.0
nxp contact k32w0+release FLASH 575604 575604 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590736 590736 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609680 609680 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674224 674224 0 0.0
RAM 82808 82808 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613428 1613428 0 0.0
RAM 207132 207132 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534228 1534252 24 0.0
RAM 204036 204036 0 0.0
light cy8ckit_062s2_43012 FLASH 1461092 1461092 0 0.0
RAM 197316 197316 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462844 1462844 0 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 650576 650576 0 0.0
RAM 104556 104556 0 0.0
lock-app qpg6105+debug FLASH 610700 610700 0 0.0
RAM 99232 99232 0 0.0
stm32 light STM32WB5MM-DK FLASH 472112 472112 0 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625532 625532 0 0.0
RAM 49904 49904 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 602572 602572 0 0.0
RAM 130288 130288 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770694 770730 36 0.0
RAM 110052 110052 0 0.0
bridge-app tlsr9258a FLASH 668618 668618 0 0.0
RAM 94672 94672 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 627254 627254 0 0.0
RAM 49948 49948 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713368 713368 0 0.0
RAM 76540 76540 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 558240 558240 0 0.0
RAM 126544 126544 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793320 793320 0 0.0
RAM 99900 99900 0 0.0
lock-app-dfu tlsr9528a FLASH 660356 660356 0 0.0
RAM 69228 69228 0 0.0
ota-requestor-app tlsr9258a FLASH 687236 687236 0 0.0
RAM 94396 94396 0 0.0
pump-app tlsr9518adk80d FLASH 609474 609474 0 0.0
RAM 56328 56328 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599860 599860 0 0.0
RAM 56128 56128 0 0.0
shell tlsr9518adk80d FLASH 462614 462614 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633616 633616 0 0.0
RAM 51576 51576 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642974 642974 0 0.0
RAM 59764 59764 0 0.0
thermostat tlsr9518adk80d FLASH 618750 618750 0 0.0
RAM 56452 56452 0 0.0
window-covering tlsr9118bdk40d FLASH 464942 464942 0 0.0
RAM 82224 82224 0 0.0
tizen all-clusters-app arm unknown 1548 1548 0 0.0
FLASH 1621556 1621556 0 0.0
RAM 45420 45420 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15767058 15767210 152 0.0
RAM 6917600 6917600 0 0.0

@@ -225,6 +225,7 @@ CHIP_ERROR ApplicationBasicAttrAccess::ReadApplicationAttribute(app::AttributeVa

CHIP_ERROR ApplicationBasicAttrAccess::ReadStatusAttribute(app::AttributeValueEncoder & aEncoder, Delegate * delegate)
{
ChipLogProgress(DeviceLayer, "Here 1");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a useful log.

Comment on lines +54 to +57
<item name="NotInstalled" value="0x04"/>
<item name="Installing" value="0x05"/>
<item name="InstallationFailed" value="0x06"/>
<item name="Installed" value="0x07"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these in the spec. Why are we adding random non-spec bits here?

Copy link

github-actions bot commented Jun 21, 2024

PR #33982: Size comparison from 9d56786 to 98235b2

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 9d56786 98235b2 change % change
bl602 lighting-app bl602 FLASH 1270534 1270534 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284812 1284812 0 0.0
RAM 95480 95480 0 0.0
bl602+rpc FLASH 1309734 1309734 0 0.0
RAM 103760 103760 0 0.0
bl702 lighting-app bl702 FLASH 1091430 1091430 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1102124 1102124 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1181240 1181240 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 874774 874774 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1127068 1127068 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1078316 1078316 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1089578 1089578 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798100 798100 0 0.0
RAM 103088 103088 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813752 813752 0 0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803276 803276 0 0.0
RAM 107688 107688 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756052 756052 0 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741724 741724 0 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605750 605750 0 0.0
RAM 204512 204512 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650770 650770 0 0.0
RAM 204772 204772 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 665865 665865 0 0.0
RAM 75100 75100 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 685725 685725 0 0.0
RAM 77732 77732 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 685725 685725 0 0.0
RAM 77732 77732 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 642653 642653 0 0.0
RAM 70168 70168 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608337 608337 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 627965 627965 0 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 627965 627965 0 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623817 623817 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643533 643533 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643533 643533 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 592389 592389 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 612233 612233 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 612233 612233 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 888232 888224 -8 -0.0
RAM 183424 183424 0 0.0
lock-app BRD4338a FLASH 699848 699848 0 0.0
RAM 242228 242228 0 0.0
window-app BRD4187C FLASH 969748 969748 0 0.0
RAM 167856 167856 0 0.0
esp32 all-clusters-app c3devkit DRAM 88324 88324 0 0.0
FLASH 1468934 1468934 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1538059 1538059 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2528192 2528192 0 0.0
RAM 125072 125072 0 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5578270 5578334 64 0.0
RAM 479304 479432 128 0.0
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5050696 5050744 48 0.0
RAM 232856 232856 0 0.0
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4476408 4476408 0 0.0
RAM 212768 212768 0 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11548231 11548295 64 0.0
RAM 531386 531514 128 0.0
chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10680388 10680436 48 0.0
RAM 580120 580248 128 0.0
fabric-admin debug unknown 5584 5584 0 0.0
FLASH 10547127 10547191 64 0.0
RAM 525466 525594 128 0.0
fabric-bridge-app debug unknown 5264 5264 0 0.0
FLASH 4346936 4346936 0 0.0
RAM 204896 204896 0 0.0
lighting-app debug+rpc+ui unknown 5904 5904 0 0.0
FLASH 5372770 5372770 0 0.0
RAM 221672 221672 0 0.0
lock-app debug unknown 5192 5192 0 0.0
FLASH 4540008 4540008 0 0.0
RAM 200192 200192 0 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4195768 4195768 0 0.0
RAM 194432 194432 0 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4321256 4321256 0 0.0
RAM 199088 199088 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2793965 2793965 0 0.0
RAM 150416 150416 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4167060 4167060 0 0.0
RAM 235784 235784 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5593624 5596232 2608 0.0
RAM 341672 341672 0 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9595926 9595926 0 0.0
RAM 348848 348848 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502020 1502020 0 0.0
RAM 226672 226672 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 880892 880892 0 0.0
RAM 139693 139693 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 951704 951704 0 0.0
RAM 138121 138121 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 826448 826472 24 0.0
RAM 138591 138591 0 0.0
nxp contact k32w0+release FLASH 575604 575604 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590728 590728 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609680 609680 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674232 674232 0 0.0
RAM 82808 82808 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613444 1613444 0 0.0
RAM 207132 207132 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534228 1534252 24 0.0
RAM 204036 204036 0 0.0
light cy8ckit_062s2_43012 FLASH 1461092 1461092 0 0.0
RAM 197316 197316 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462844 1462844 0 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 650600 650600 0 0.0
RAM 104556 104556 0 0.0
lock-app qpg6105+debug FLASH 610700 610700 0 0.0
RAM 99232 99232 0 0.0
stm32 light STM32WB5MM-DK FLASH 472136 472136 0 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632130 632130 0 0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 657126 657126 0 0.0
RAM 145872 145872 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 777190 777226 36 0.0
RAM 110684 110684 0 0.0
bridge-app tlsr9258a FLASH 675114 675114 0 0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 633714 633714 0 0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 719492 719492 0 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 612268 612268 0 0.0
RAM 142104 142104 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 799822 799822 0 0.0
RAM 100508 100508 0 0.0
lock-app-dfu tlsr9528a FLASH 665278 665278 0 0.0
RAM 69860 69860 0 0.0
ota-requestor-app tlsr9258a FLASH 694444 694444 0 0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 615978 615978 0 0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 606362 606362 0 0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466154 466154 0 0.0
RAM 72484 72484 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 640074 640074 0 0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 650188 650188 0 0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 625252 625252 0 0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 518710 518710 0 0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1560 1560 0 0.0
FLASH 1633264 1633264 0 0.0
RAM 46020 46020 0 0.0
chip-tool-ubsan arm unknown 2364 2364 0 0.0
FLASH 15881842 15881994 152 0.0
RAM 6972008 6972008 0 0.0

Copy link

github-actions bot commented Jun 24, 2024

PR #33982: Size comparison from 7c04979 to 694132b

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 7c04979 694132b change % change
bl602 lighting-app bl602 FLASH 1270550 1270550 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284828 1284828 0 0.0
RAM 95480 95480 0 0.0
bl602+rpc FLASH 1309750 1309750 0 0.0
RAM 103760 103760 0 0.0
bl702 lighting-app bl702 FLASH 1091446 1091446 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1102140 1102140 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1181256 1181256 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 874790 874790 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1127090 1127090 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1078332 1078332 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1089594 1089594 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798004 798004 0 0.0
RAM 103088 103088 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813768 813768 0 0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803292 803292 0 0.0
RAM 107688 107688 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756068 756068 0 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741732 741732 0 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605766 605766 0 0.0
RAM 204512 204512 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650786 650786 0 0.0
RAM 204772 204772 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 665785 665785 0 0.0
RAM 75100 75100 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 685645 685645 0 0.0
RAM 77732 77732 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 685645 685645 0 0.0
RAM 77732 77732 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 642573 642573 0 0.0
RAM 70168 70168 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608345 608345 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 627973 627973 0 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 627973 627973 0 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623833 623833 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643541 643541 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643541 643541 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 592397 592397 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 612249 612249 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 612249 612249 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 888136 888128 -8 -0.0
RAM 183424 183424 0 0.0
lock-app BRD4338a FLASH 699864 699864 0 0.0
RAM 242228 242228 0 0.0
window-app BRD4187C FLASH 969748 969748 0 0.0
RAM 167856 167856 0 0.0
esp32 all-clusters-app c3devkit DRAM 88324 88324 0 0.0
FLASH 1468846 1468846 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1537971 1537971 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2528240 2528240 0 0.0
RAM 125072 125072 0 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5577966 5578030 64 0.0
RAM 479304 479432 128 0.0
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5050424 5050472 48 0.0
RAM 232856 232856 0 0.0
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4476456 4476456 0 0.0
RAM 212768 212768 0 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11548279 11548343 64 0.0
RAM 531386 531514 128 0.0
chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10680468 10680516 48 0.0
RAM 580120 580248 128 0.0
fabric-admin debug unknown 5584 5584 0 0.0
FLASH 10547175 10547239 64 0.0
RAM 525466 525594 128 0.0
fabric-bridge-app debug unknown 5264 5264 0 0.0
FLASH 4346984 4346984 0 0.0
RAM 204896 204896 0 0.0
lighting-app debug+rpc+ui unknown 5904 5904 0 0.0
FLASH 5372466 5372466 0 0.0
RAM 221672 221672 0 0.0
lock-app debug unknown 5192 5192 0 0.0
FLASH 4540056 4540056 0 0.0
RAM 200192 200192 0 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4195816 4195816 0 0.0
RAM 194432 194432 0 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4321304 4321304 0 0.0
RAM 199088 199088 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2793693 2793693 0 0.0
RAM 150416 150416 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4167108 4167108 0 0.0
RAM 235784 235784 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5593704 5596312 2608 0.0
RAM 341672 341672 0 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9595958 9595958 0 0.0
RAM 348848 348848 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502084 1502084 0 0.0
RAM 226672 226672 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 880800 880800 0 0.0
RAM 139693 139693 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 951612 951612 0 0.0
RAM 138121 138121 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 826356 826380 24 0.0
RAM 138591 138591 0 0.0
nxp contact k32w0+release FLASH 575620 575620 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590744 590744 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609696 609696 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674240 674240 0 0.0
RAM 82808 82808 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613348 1613348 0 0.0
RAM 207132 207132 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534116 1534140 24 0.0
RAM 204036 204036 0 0.0
light cy8ckit_062s2_43012 FLASH 1460996 1460996 0 0.0
RAM 197316 197316 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462860 1462860 0 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 650608 650608 0 0.0
RAM 104556 104556 0 0.0
lock-app qpg6105+debug FLASH 610708 610708 0 0.0
RAM 99232 99232 0 0.0
stm32 light STM32WB5MM-DK FLASH 472048 472048 0 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632146 632146 0 0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 657038 657038 0 0.0
RAM 145872 145872 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 777102 777138 36 0.0
RAM 110684 110684 0 0.0
bridge-app tlsr9258a FLASH 675130 675130 0 0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 633730 633730 0 0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 719508 719508 0 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 612180 612180 0 0.0
RAM 142104 142104 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 799734 799734 0 0.0
RAM 100508 100508 0 0.0
lock-app-dfu tlsr9528a FLASH 665294 665294 0 0.0
RAM 69860 69860 0 0.0
ota-requestor-app tlsr9258a FLASH 694460 694460 0 0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 615994 615994 0 0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 606378 606378 0 0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466170 466170 0 0.0
RAM 72484 72484 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 640090 640090 0 0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 650204 650204 0 0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 625268 625268 0 0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 518726 518726 0 0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1560 1560 0 0.0
FLASH 1633100 1633100 0 0.0
RAM 46020 46020 0 0.0
chip-tool-ubsan arm unknown 2364 2364 0 0.0
FLASH 15882050 15882202 152 0.0
RAM 6972112 6972112 0 0.0

@lazarkov lazarkov closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants