Update Matter Casting automation test script to use the simplified Linux tv-casting-app build command in the workflow yaml file. #34037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nux tv-casting-app build command in the workflow yaml file.
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
pullapprove
bot
requested review from
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34037: Size comparison from 9d56786 to 2170d80 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jun 21, 2024
andy31415
reviewed
Jun 21, 2024
sharadb-amazon
approved these changes
Jun 21, 2024
|
PR #34037: Size comparison from 9d56786 to 8819050 Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
…condition that always return true in simple-app-helper.cpp:392.
|
PR #34037: Size comparison from 9d56786 to e46b93f Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34037: Size comparison from 9d56786 to 620ec71 Full report (22 builds for cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34037: Size comparison from 9d56786 to 66eb42a Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jun 24, 2024
andy31415
reviewed
Jun 24, 2024
chrisdecenzo
approved these changes
Jun 25, 2024
andy31415
approved these changes
Jun 25, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…nux tv-casting-app build command in the workflow yaml file. (project-chip#34037) * Update Matter Casting automation test script to use the simplified Linux tv-casting-app build command in the workflow yaml file. * Fix Linux tv-casting-app build issue by adding to args.gni file. * Fix Linux tv-casting-app build issue by removing unneeded comparison condition that always return true in simple-app-helper.cpp:392. * Addressed PR comments from @andy31415. * Fix lint and unit tests issues. * Addressed PR comment from @andy31415. * Addressed PR comment from @andy31415.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current Matter Casting automation test script is configured for the old Linux tv-casting-app build as defined in the workflow yaml file. We need to update the yaml file to make the test script work for the new simplified build of the Linux tv-casting-app. Additionally, all the strings used in the
commissionee_generated_passcode_testsequence are currently from the core SDK. We need to substitute these strings with their equivalents from the tv-casting library or tv-casting-app, where feasible. This way, the test script would be less prone to failure in the event of string format changes in the core SDK. Lastly, improvements could be made to thesend_input_cmd_to_subprocessfunction along with the way we are removing cached entries.Solution
chip_casting_simplifiedsupport tobuild_examples.pyby changinghost.pyto support this flag and add a variant that is conditional totargets.py.scripts/examples/gn_build_example.sh examples/tv-casting-app/linux/ out/tv-casting-apptoscripts/examples/gn_build_example.sh examples/tv-casting-app/linux/ out/tv-casting-app chip_casting_simplified=true.send_input_cmd_to_subprocessfunction by removing unnecessary code.os.removeinstead ofos.systemas the former is more aligned with Python best practices.Testing
Tested locally to ensure the test script works as expected.