-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to allow LP_EM_CC1354P10_1 build #34069
base: master
Are you sure you want to change the base?
Conversation
@@ -191,15 +191,16 @@ ble.numOfAdvSets = 1; | |||
ble.lockProject = true; | |||
ble.oneLibSizeOpt = true; | |||
ble.maxPDUSize = 255; | |||
ble.radioConfig.codeExportConfig.$name = "ti_devices_radioconfig_code_export_param1"; | |||
ble.radioConfig.codeExportConfig.$name = "ti_devices_radioconfig_code_export_param0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is required to avoid the following build error.
error: /ti/ble5stack/ble radioConfig.codeExportConfig.$name: Duplicate name: 'ti_devices_radioconfig_code_export_param1' also exists on instance(s) of Code Export Configuration
error: /ti/devices/radioconfig/custom radioConfigieee154.codeExportConfig.$name: Duplicate name: 'ti_devices_radioconfig_code_export_param1' also exists on instance(s) of Code Export Configuration
The build for LP_EM_CC1454P10_6
only worked as something in the redesign of syscfg renamed the ble.radioConfig.codeExportConfig.$name
when setting ble.rfDesign
to LP_EM_CC1354P10_6
.
ti_devices_radioconfig_code_export_param0
seem a more correct name as the ble codeExportConfig is set to this for other ble examples.
Below was used to debug and confirm this.
+console.log("RFCustom.radioConfigieee154p10.codeExportConfig: ", ble.radioConfig.codeExportConfig.$name);
/* BLE */
ble.addressMode = "ADDRMODE_RP_WITH_PUBLIC_ID";
ble.maxConnNum = 1;
@@ -194,6 +195,7 @@ ble.lockProject = true;
ble.oneLibSizeOpt = true;
ble.maxPDUSize = 255;
ble.radioConfig.codeExportConfig.$name = "ti_devices_radioconfig_code_export_param1";
+console.log("ble.radioConfig.codeExportConfig.$name : ", ble.radioConfig.codeExportConfig.$name);
ble.connUpdateParamsPeripheral.$name = "ti_ble5stack_general_ble_conn_update_params0";
ble.connUpdateParamsPeripheral.reqMinConnInt = 30;
ble.connUpdateParamsPeripheral.reqMaxConnInt = 50;
@@ -202,6 +204,8 @@ ble.advSet1.$name = "ti_ble5stack_broadc
ble.advSet1.advParam1.$name = "ti_ble5stack_broadcaster_advertisement_params0";
ble.rfDesign = "LP_EM_CC1354P10_6";
+console.log("ble.radioConfig.codeExportConfig.$name : ", ble.radioConfig.codeExportConfig.$name)
+error()
Generating an output of:
RFCustom.radioConfigieee154p10.codeExportConfig: ti_devices_radioconfig_code_export_param0
ble.radioConfig.codeExportConfig.$name : ti_devices_radioconfig_code_export_param1
ble.radioConfig.codeExportConfig.$name : ti_devices_radioconfig_code_export_param0
PR #34069: Size comparison from 686e73b to b221c9c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Changing the default build target from
LP_EM_CC1354P10_6
toLP_EM_CC1354P10_1
requires changes in multiple place and is not intuitive.This PR make it easier to change the build target to
LP_EM_CC1354P10_1
and has been documented in the README.