Serialize ContentApp SupportedCluster set #34144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #34144: Size comparison from d033f8b to 5515a49 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
mthiesc
force-pushed
the
serialize-contentapp-supported-clusters
branch
from
5515a49 to
220abf8
Compare
|
PR #34144: Size comparison from 102faca to 220abf8 Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
mthiesc
force-pushed
the
serialize-contentapp-supported-clusters
branch
from
220abf8 to
1665f45
Compare
|
PR #34144: Size comparison from a8fe0cf to 1665f45 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
mthiesc
force-pushed
the
serialize-contentapp-supported-clusters
branch
from
1665f45 to
6edb6c6
Compare
|
PR #34144: Size comparison from ca57b59 to 6edb6c6 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34144: Size comparison from ca57b59 to f8a663c Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve and
harimau-qirex
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34144: Size comparison from 6e31453 to 578a75c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34144: Size comparison from 8786012 to 3d13852 Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
lazarkov
approved these changes
Jul 8, 2024
|
PR #34144: Size comparison from 8786012 to 28764b8 Full report (4 builds for cc32xx, mbed, stm32)
|
|
PR #34144: Size comparison from 8786012 to a44158f Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34144: Size comparison from 90310f2 to 6010a5f Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34144: Size comparison from 9306418 to e0b51d9 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34144: Size comparison from 8ebe19d to b56e6fa Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jul 11, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 18, 2024
* Serialize ContentApp SupportedCluster set * Restyled by google-java-format * Update EndpointsDataStore.java * Restyled by google-java-format --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Lazar Kovacic <lkovacic@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Problem]
The EndpointsDatastore (de)serializes ContentApp info for persistent storage. The ContentApp SupportedCluster set is not included in the serialization.
[Solution]
Extend EndpointsDatastore serializeContentApp/deserializeContenApp methods to include the SupportedCluster set.
[Test]
Tested using TV Android App. Here's what's been stored after serialisation
{ "VID": 65521, "VN": "CSA", "PID": 32769, "VER": "1", "EPID": 5, "supportedClusters": [ { "clusterIdentifier": 1290, "features": 0, "optionalCommandIdentifiers": [], "optionalAttributesIdentifiers": [] }, { "clusterIdentifier": 1286, "features": 0, "optionalCommandIdentifiers": [], "optionalAttributesIdentifiers": [] }, { "clusterIdentifier": 1294, "features": 0, "optionalCommandIdentifiers": [], "optionalAttributesIdentifiers": [] }, { "clusterIdentifier": 1289, "features": 0, "optionalCommandIdentifiers": [], "optionalAttributesIdentifiers": [] } ] }