Update UniqueID in the BasicInformationCluster to align with the spec #34166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #34166: Size comparison from fba5793 to 1e2e353 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 3, 2024
Damian-Nordic
approved these changes
Jul 3, 2024
yufengwangca
added
the
skip-protocol-compatibility
|
PR #34166: Size comparison from 70744ed to 6fb3378 Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
|
PR #34166: Size comparison from 70744ed to e0b9e92 Full report (22 builds for cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34166: Size comparison from ee0d96e to 7c559e5 Full report (6 builds for cc32xx, mbed, stm32, tizen)
|
|
PR #34166: Size comparison from ee0d96e to 748e5b4 Full report (6 builds for cc32xx, mbed, stm32, tizen)
|
|
PR #34166: Size comparison from ee0d96e to d894244 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…project-chip#34166) * Update UniqueID in the BasicInformationCluster * Run codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only update the xml definition and re-run codegen, the bridge change to generate a unique id
on behalf of the bridged device if there is no one will be in the following PR.
NOTE: This PR breaks backward compatibility due to the changes in CHIP-Specifications/connectedhomeip-spec#9062. Controllers introduced after version 1.4 will assume that this attribute is always available, but older devices with previous versions will not provide it.
Fixes #33220