Fix handle cleanup in CommandHandler. #34262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a CommandHandler went away, it invalidated its handles, but did not remove them from the list. This would cause it to fail a fatal assert when the non-empty list was destroyed. The fix is to clear the list once we have invalidated all the handles, since we no longer need to track them once they have been invalidated.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
pullapprove
bot
requested review from
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #34262: Size comparison from 9d3d8d2 to 3bca692 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
approved these changes
Jul 9, 2024
woody-apple
approved these changes
Jul 9, 2024
|
Note: This is a crash reported from the wild |
|
Fast tracking quality fix |
lazarkov
pushed a commit
to lazarkov/connectedhomeip
that referenced
this pull request
Jul 10, 2024
When a CommandHandler went away, it invalidated its handles, but did not remove them from the list. This would cause it to fail a fatal assert when the non-empty list was destroyed. The fix is to clear the list once we have invalidated all the handles, since we no longer need to track them once they have been invalidated.
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
When a CommandHandler went away, it invalidated its handles, but did not remove them from the list. This would cause it to fail a fatal assert when the non-empty list was destroyed. The fix is to clear the list once we have invalidated all the handles, since we no longer need to track them once they have been invalidated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a CommandHandler went away, it invalidated its handles, but did not remove them from the list. This would cause it to fail a fatal assert when the non-empty list was destroyed.
The fix is to clear the list once we have invalidated all the handles, since we no longer need to track them once they have been invalidated.