-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .gitignore - adds py environment folder #34265
Conversation
Update .gitignore - adds py environment folder
PR #34265: Size comparison from c91c3e0 to 59e809d Full report (21 builds for mbed, nrfconnect, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a py
environment folder? What build process creates that?
I do not have such a thing.
Specifcally:
We have to figure out what build command creates it and dirties the source tree. Please add this information to the PR summary so we can determine if the command is buggy or if we really need to ignore (and add details to gitignore). Just ignoring things that dirty our source tree is not ok (we should not accept dirtying of the source tree) |
This command creates it Explanation is here: connectedhomeip/docs/testing/python.md Lines 517 to 523 in bf4edc4
|
I can update it to this |
Shouldn't builds go into |
We should fix the documentation to place it in |
Closing old PR: we have in the mean time updated our documentation in a different PR (#35901) |
Update .gitignore - adds py environment folder
All the files and folders in the py environment folder are appearing as new changes to commit. This repository doesn't include that folder, so I added the py folder to ignore it.
This command creates the py environment folder:
./scripts/build_python.sh -i py
Explanation is here:
connectedhomeip/docs/testing/python.md
Lines 517 to 523 in bf4edc4