Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore - adds py environment folder #34265

Closed
wants to merge 1 commit into from

Conversation

raul-marquez-csa
Copy link
Contributor

@raul-marquez-csa raul-marquez-csa commented Jul 9, 2024

Update .gitignore - adds py environment folder

All the files and folders in the py environment folder are appearing as new changes to commit. This repository doesn't include that folder, so I added the py folder to ignore it.

This command creates the py environment folder:
./scripts/build_python.sh -i py

Explanation is here:

Next build the python wheels and create / activate a venv (called `py` here, but
any name may be used)
```
./scripts/build_python.sh -i py
source py/bin/activate
```

Update .gitignore - adds py environment folder
Copy link

github-actions bot commented Jul 9, 2024

PR #34265: Size comparison from c91c3e0 to 59e809d

Full report (21 builds for mbed, nrfconnect, telink)
platform target config section c91c3e0 59e809d change % change
mbed lock-app-release cy8cproto_062_4343w FLASH 1502420 1502420 0 0.0
RAM 226640 226640 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 882276 882276 0 0.0
RAM 142109 142109 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 952864 952864 0 0.0
RAM 140537 140537 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 827876 827876 0 0.0
RAM 141023 141023 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632600 632600 0 0.0
RAM 50424 50424 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 658400 658400 0 0.0
RAM 148296 148296 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 778766 778766 0 0.0
RAM 113116 113116 0 0.0
bridge-app tlsr9258a FLASH 675586 675586 0 0.0
RAM 95200 95200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634184 634184 0 0.0
RAM 50468 50468 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720058 720058 0 0.0
RAM 77044 77044 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 613588 613588 0 0.0
RAM 144532 144532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801340 801340 0 0.0
RAM 102936 102936 0 0.0
lock-app-dfu tlsr9528a FLASH 665750 665750 0 0.0
RAM 69756 69756 0 0.0
ota-requestor-app tlsr9258a FLASH 694916 694916 0 0.0
RAM 94924 94924 0 0.0
pump-app tlsr9518adk80d FLASH 616448 616448 0 0.0
RAM 56848 56848 0 0.0
pump-controller-app tlsr9518adk80d FLASH 606832 606832 0 0.0
RAM 56648 56648 0 0.0
shell tlsr9518adk80d FLASH 466316 466316 0 0.0
RAM 72460 72460 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 640802 640802 0 0.0
RAM 52096 52096 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 650658 650658 0 0.0
RAM 60284 60284 0 0.0
thermostat tlsr9518adk80d FLASH 625722 625722 0 0.0
RAM 56980 56980 0 0.0
window-covering tlsr9118bdk40d FLASH 518982 518982 0 0.0
RAM 97696 97696 0 0.0

Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a py environment folder? What build process creates that?

I do not have such a thing.

@andy31415
Copy link
Contributor

What is a py environment folder? What build process creates that?

I do not have such a thing.

Specifcally:

  • name does not feel special (no __ prefix nor . even for hidden)
  • name is actually common, like scripts/tests/py/ and src/test_driver/efr32/py/

We have to figure out what build command creates it and dirties the source tree. Please add this information to the PR summary so we can determine if the command is buggy or if we really need to ignore (and add details to gitignore).

Just ignoring things that dirty our source tree is not ok (we should not accept dirtying of the source tree)

@raul-marquez-csa
Copy link
Contributor Author

What is a py environment folder? What build process creates that?
I do not have such a thing.

Specifcally:

  • name does not feel special (no __ prefix nor . even for hidden)
  • name is actually common, like scripts/tests/py/ and src/test_driver/efr32/py/

We have to figure out what build command creates it and dirties the source tree. Please add this information to the PR summary so we can determine if the command is buggy or if we really need to ignore (and add details to gitignore).

Just ignoring things that dirty our source tree is not ok (we should not accept dirtying of the source tree)

This command creates it
./scripts/build_python.sh -i py

Explanation is here:

Next build the python wheels and create / activate a venv (called `py` here, but
any name may be used)
```
./scripts/build_python.sh -i py
source py/bin/activate
```

@raul-marquez-csa
Copy link
Contributor Author

I can update it to this
/py
This will only target the py folder in the root folder, not subfolders

@bzbarsky-apple
Copy link
Contributor

Shouldn't builds go into out or something like that which already gets gitignored?

@andy31415
Copy link
Contributor

What is a py environment folder? What build process creates that?
I do not have such a thing.

Specifcally:

  • name does not feel special (no __ prefix nor . even for hidden)
  • name is actually common, like scripts/tests/py/ and src/test_driver/efr32/py/

We have to figure out what build command creates it and dirties the source tree. Please add this information to the PR summary so we can determine if the command is buggy or if we really need to ignore (and add details to gitignore).
Just ignoring things that dirty our source tree is not ok (we should not accept dirtying of the source tree)

This command creates it ./scripts/build_python.sh -i py

Explanation is here:

Next build the python wheels and create / activate a venv (called `py` here, but
any name may be used)
```
./scripts/build_python.sh -i py
source py/bin/activate
```

We should fix the documentation to place it in out/py.

@andy31415
Copy link
Contributor

Closing old PR: we have in the mean time updated our documentation in a different PR (#35901)

@andy31415 andy31415 closed this Oct 10, 2024
@andy31415 andy31415 deleted the add-py-env-folder-to-gitignore branch October 10, 2024 12:17
@raul-marquez-csa raul-marquez-csa self-assigned this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants