Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add water heater management cluster sdk support #34339

Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
dcb4a57
Add base water-heater-mode-cluster support into control files and reg…
PeterC1965 Jul 15, 2024
6935f04
Add support for the water-heater-management cluster SDK
PeterC1965 Jul 15, 2024
f230cfa
Add support for the water-heater-management cluster SDK
PeterC1965 Jul 15, 2024
c2ee681
Add support for the water-heater-management cluster SDK
PeterC1965 Jul 15, 2024
cbbacdb
Add support for the water-heater-management cluster SDK
PeterC1965 Jul 15, 2024
624d9c6
Define chip_enable_water_heater_management_trigger and CHIP_DEVICE_CO…
PeterC1965 Jul 15, 2024
be2a49c
Restyled by isort
restyled-commits Jul 15, 2024
ca7ad50
Add accidentally deleted Mode_WaterHeater.xml back
PeterC1965 Jul 15, 2024
6f49b11
Address review comments from Tennessee Carmel-Veilleux
PeterC1965 Jul 16, 2024
aab0be3
Add WaterHeaterManagementTestEventTriggerHandler.h
PeterC1965 Jul 16, 2024
c837678
Apply various review comments from Boris Zbarsky
PeterC1965 Jul 16, 2024
6c93f6a
Apply various review comments from Boris Zbarsky
PeterC1965 Jul 16, 2024
fc7188a
Addressing review comments from Boris
PeterC1965 Jul 18, 2024
5493664
Addressing review comments from Boris
PeterC1965 Jul 18, 2024
97e6d41
Restyled by whitespace
restyled-commits Jul 18, 2024
bd879b5
Restyled by clang-format
restyled-commits Jul 18, 2024
1668d3a
Merge branch 'master' into add-water-heater-management-cluster-sdk-su…
PeterC1965 Jul 18, 2024
2c43cf0
Address review comment from Tennessee
PeterC1965 Jul 18, 2024
65e7542
Update with review comments from Boris
PeterC1965 Jul 21, 2024
1626daa
Merge branch 'master' into add-water-heater-management-cluster-sdk-su…
PeterC1965 Jul 22, 2024
d38c545
Fix compilation introduced during merge
PeterC1965 Jul 22, 2024
b10398c
Merge branch 'master' into add-water-heater-management-cluster-sdk-su…
PeterC1965 Jul 23, 2024
cf319aa
Merge branch 'master' into add-water-heater-management-cluster-sdk-su…
PeterC1965 Jul 25, 2024
46cd339
Merge branch 'master' into add-water-heater-management-cluster-sdk-su…
PeterC1965 Jul 25, 2024
5c21924
Merge branch 'master' into add-water-heater-management-cluster-sdk-su…
PeterC1965 Jul 26, 2024
e458e09
Merge branch 'master' into add-water-heater-management-cluster-sdk-su…
PeterC1965 Jul 26, 2024
a167c34
Merge branch 'master' into add-water-heater-management-cluster-sdk-su…
PeterC1965 Jul 27, 2024
628dd91
Merge branch 'master' into add-water-heater-management-cluster-sdk-su…
PeterC1965 Jul 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Addressing review comments from Boris
  • Loading branch information
PeterC1965 committed Jul 18, 2024
commit 54936640ba642d1a89a20c073cda62aafb6a1b0d
Original file line number Diff line number Diff line change
@@ -69,8 +69,8 @@ class Delegate
*/
virtual Protocols::InteractionModel::Status HandleBoost(uint32_t duration, Optional<bool> oneShot,
Optional<bool> emergencyBoost, Optional<int16_t> temporarySetpoint,
Optional<chip::Percent> targetPercentage,
Optional<chip::Percent> targetReheat) = 0;
Optional<Percent> targetPercentage,
Optional<Percent> targetReheat) = 0;

/**
* @brief Delegate should implement a handler to cancel a boost command.