Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External sdk support #34371

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

External sdk support #34371

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
398b16f
Added gn option for external sdk target
rasmus-zyax Jul 11, 2024
8ece47b
Updated SDK target picking
rasmus-zyax Jul 26, 2024
6074693
Added gn option for external sdk target
rasmus-zyax Jul 11, 2024
e788734
Updated SDK target picking
rasmus-zyax Jul 26, 2024
9bc2ed3
Updated SDK var
rasmus-zyax Jul 26, 2024
62055a1
Updated SDK target picking
rasmus-zyax Jul 26, 2024
76323e4
Updated SDK var
rasmus-zyax Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/system/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ declare_args() {
#
# see https://clang.llvm.org/docs/ThreadSafetyAnalysis.html
chip_enable_thread_safety_checks = is_clang

chip_external_sdk_target = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add documentation on how this is indended to be used.

Why don't we default this to the ${efr32_sdk_build_root}:efr32_sdk" or other values depending on the platform and then let others override this? This seems to be more consistent than adding a completely separate flag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose a chip_platform_sdk_target path that gets initialized like the existing deps, but allows overriding.

}

if (chip_project_config_include_dirs == [] &&
Expand Down Expand Up @@ -197,6 +199,9 @@ source_set("system_config_header") {
if (chip_device_platform == "bl702l") {
public_deps += [ "${bouffalolab_iot_sdk_build_root}/bl702l:bl_iot_sdk" ]
}
if (chip_external_sdk_target != "") {
public_deps += [ "${chip_external_sdk_target}" ]
}

# Add platform here as needed.
}
Expand Down
Loading