-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements the Commissioner Control Cluster in Matter SDK #34375
Merged
tehampson
merged 14 commits into
project-chip:master
from
yufengwangca:pr/cluster/commissioner
Jul 26, 2024
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2892292
Implement Commissioner Control cluster server
yufengwangca 801ddc6
Update src/app/clusters/commissioner-control-server/commissioner-cont…
yufengwangca c804c98
Address review comments
yufengwangca 6f17e1d
Update src/app/clusters/commissioner-control-server/commissioner-cont…
yufengwangca 4f6c80d
Update src/app/clusters/commissioner-control-server/commissioner-cont…
yufengwangca b451305
Move MatterCommissionerControlPluginServerInitCallback from applicati…
yufengwangca d96cfbc
Return kUndefinedNodeId if get the NodeID from a group or PASE session.
yufengwangca bff49d6
Add case requirement to CommissionerControlCluster
yufengwangca b0cbeb1
Restyled by clang-format
restyled-commits e06ce4a
Address PR comments
tehampson d56a7f7
Few more fixes
tehampson 53b1e8a
Restyled by clang-format
restyled-commits 165f4dc
Add GetCommissioningWindowParams back in
tehampson 73c331e
Restyled by whitespace
restyled-commits File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tehampson Is that OK, that the CommissionerControl is on endpoint 0? In the spec, the CommissionerControl should be on Aggregator endpoint, which is endpoint 1 here.