MTRDevice XPC Interface #34547
Closed
MTRDevice XPC Interface #34547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #34547: Size comparison from 55786a0 to 817ade3 Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #34547: Size comparison from 55786a0 to da51f2b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jtung-apple
reviewed
Jul 27, 2024
| @@ -0,0 +1,47 @@ | |||
| // | |||
There was a problem hiding this comment.
Please remove this line.
There was a problem hiding this comment.
i think this is part of the project new file template so we should probably also fix it there
jtung-apple
reviewed
Jul 27, 2024
jtung-apple
reviewed
Jul 27, 2024
| @@ -0,0 +1,54 @@ | |||
| // | |||
There was a problem hiding this comment.
Please remove this line.
woody-apple
reviewed
Jul 27, 2024
| attributeID:(NSNumber *)attributeID | ||
| params:(MTRReadParams * _Nullable)params | ||
| resultHandler:(MTRDeviceXPCServerAttributeReadResult)resultHandler; | ||
|
|
There was a problem hiding this comment.
I'd also add a method that has a -(BOOL)returningSomething; signature to test that path too.
|
PR #34547: Size comparison from 55786a0 to a51e83c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
force-pushed
the
darwin-mtrdevice-xpc
branch
from
c1f15b8 to
a51e83c
Compare
|
PR #34547: Size comparison from 08dfc13 to a51e83c Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #34547: Size comparison from 08dfc13 to ef9ac76 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
commented
Jul 31, 2024
woody-apple
reviewed
Aug 2, 2024
| #import "MTRDeviceController_Internal.h" | ||
| #import "MTRLogging_Internal.h" | ||
|
|
||
| @implementation MTRRemoteDeviceController |
There was a problem hiding this comment.
Can we call this MTRDeviceController_XPC?
woody-apple
reviewed
Aug 2, 2024
| #pragma once | ||
|
|
||
| @interface MTRRemoteDeviceControllerParameters () | ||
| @property (nonatomic, strong, readonly) NSString * xpcServiceName; |
There was a problem hiding this comment.
atomic, copy, readonly?
woody-apple
reviewed
Aug 2, 2024
| MTR_NEWLY_AVAILABLE | ||
| @interface MTRRemoteDeviceControllerParameters : MTRDeviceControllerAbstractParameters | ||
| - (instancetype)initWithXPCServiceName:(NSString *)xpcServiceName uniqueIdentifier:(NSUUID *)uniqueIdentifier; | ||
| @property (nonatomic, strong, readonly) NSUUID * uniqueIdentifier; |
There was a problem hiding this comment.
atomic, copy, readonly?
woody-apple
reviewed
Aug 2, 2024
| @@ -308,6 +310,18 @@ - (void)setOTAProviderDelegate:(id<MTROTAProviderDelegate>)otaProviderDelegate q | |||
|
|
|||
| @end | |||
|
|
|||
| // REVIEWERS: own file? | |||
| @implementation MTRRemoteDeviceControllerParameters | |||
There was a problem hiding this comment.
I don't love remote here,
Thinking out loud: MTRDeviceControllerStartupParametersXPCService ?
woody-apple
reviewed
Aug 2, 2024
| @@ -0,0 +1,61 @@ | |||
| /** | |||
There was a problem hiding this comment.
MTRDevice_XPCHelpers/Additions/Tools/Utilities/Protocols?
I assume this will be different than the MTRDevice_XPC.m object?
There was a problem hiding this comment.
This is something I just started realizing needs to be different - there's the proxy service side and there's the proxy object that the client will use rather than just using the proxy service object directly, i.e. to get a synchronous API to match existing MTRDevice API. Thus, the time for raising MTRDevice / lowering its implementation has come. Will discuss with you shortly.
start closing off `MTRDevice` direct use add a note to self / reviewers fix `newBaseDevice` / `removeExpectedValue[s]` error ty @bzbarsky-apple move `MTRDevice_Concrete.h` to Project scope was Public note to self about coming change in MTRDeviceController move some MTRDevice utilities to MTRDevice_Internal.h where they are at least shared between MTRDevice and MTRDevice_Concrete. but probably they merit their own files - the header is getting heavy add subclass-facing init to `MTRDevice` superclass for `MTRDevice_Concrete` code was `NSObject`, but now is `MTRDevice`, which hides its `init`s. fix build of `MTRDevice_Internal.h` Revert "move some MTRDevice utilities" This reverts commit ba7331f. fix MTRDevice_Concrete block-scoped pointer types move clamped number to utilities remove duplicated MTRClampedNumber implementations more `MTRClampedNumber` cleanup duplicate MTRDeviceDelegateInfo for now restore prematurely removed `MTRDevice` methods move common `MTRDeviceClusterData` keys remove now-obsolete include for CodeUtils remove duplicate `MTRDeviceClusterData` remove duplicate key symbols from `MTRDevice_Concrete` remove availability annotations for nonpublic API Restyled by whitespace Restyled by clang-format remove superfluous init/new signatures available by default
kiel-apple
force-pushed
the
darwin-mtrdevice-xpc
branch
from
008c9ee to
d774007
Compare
|
|
|
PR #34547: Size comparison from 83dc1c8 to d774007 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
work ongoing in other branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress - goal is to get a simple test running first with a method not on MTRDevice, then start implementing MTRDevice methods