[ Test ] Creating test module TC_CADMIN_1_11 #34760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
j-ororke
commented
Aug 3, 2024
j-ororke
commented
- Test module created following matter-test-scripts task (TC-CADMIN-1.11: Automate matter-test-scripts#286):
- Test module created following matter-test-scripts task (project-chip/matter-test-scripts#286): -- Open commissioning window on DUT twice using ECM then BCM [DUT - Commissionee] -- Commission DUT to TH_CR1 (can be skipped if done in a preceding test) -- TH_CR1 reads the BasicCommissioningInfo attribute from the General Commissioning cluster on EP0 and saves the MaxCumulativeFailsafeSeconds as timeout -- TH_CR1 sends an OpenCommissioningWindow command to the DUT with the CommissioningTimeout set to timeout -- TH_CR2 fully commissions the DUT -- TH_CR1 sends an OpenCommissioningWindow command to the DUT with the CommissioningTimeout set to timeout -- TH_CR1 sends an OpenCommissioningWindow command to the DUT with the CommissioningTimeout set to timeout -- TH_CR2 sends an OpenCommissioningWindow command to the DUT with the CommissioningTimeout set to timeout -- TH_CR1 sends an RevokeCommissioning command to the DUT -- TH_CR1 reads the FeatureMap from the Administrator Commissioning Cluster. If the feature map includes the BC feature bit, repeat steps 5-8 using the OpenBasicCommissioningWindow command -- TH_CR2 reads the CurrentFabricIndex attribute from the Node Operational Credentials cluster and saves as th2_idx -- TH_CR1 sends the RemoveFabric command to the DUT with the FabricIndex set to th2_idx
|
Review changes with SemanticDiff. Analyzed 2 of 3 files.
|
github-actions
bot
added
github
workflows
tests
matter-1.4-te2-script-change
j-ororke
changed the title
|
PR #34760: Size comparison from 6ba9655 to 481445d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Updated OpenbasicCommissioningWindow to update to using correct variables.
|
PR #34760: Size comparison from 6ba9655 to 43df27f Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn and
Damian-Nordic
|
PR #34760: Size comparison from 237e450 to 77a1c5b Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Due to recent changes, had to update to using PyChipError for ctx.exception.err in order to handle error raised during commissioning properly
|
PR #34760: Size comparison from 237e450 to 508139f Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Updated method for OpenBasicCommissiongWindow with BC feature enabled
cecille
approved these changes
Oct 3, 2024
Co-authored-by: C Freeman <cecille@google.com>
|
PR #34760: Size comparison from 2651245 to 182aca3 Full report (39 builds for cc13x4_26x4, cc32xx, cyw30739, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
- Removed useTestCommissioner when creating self.th2 - Changed to using None instead of 0 as variable value for OpenCommissioningWindow() - Removed generate_unique_randow_value() as not needed in this test module
|
PR #34760: Size comparison from 2651245 to d73ba52 Full report (53 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
- Resolved linting error
|
PR #34760: Size comparison from 2651245 to cf5b4b3 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Updated due to latest changes to matter_testing support module
|
PR #34760: Size comparison from 22e9783 to b92a141 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
The YAML script for the test |
- Removed Test_TC_CADMIN_1_11.yaml - Updated TC_CADMIN_1_11 python test module to enable verbose output in CI/CD pipeline.
- Updated CI/CD nominclature for this test to match latest version
|
This script is referenced in I believe it no longer belongs there. |
- Removed Test_TC_CADMIN_1_11 from MultipleFabrics section
raul-marquez-csa
approved these changes
Oct 16, 2024
|
PR #34760: Size comparison from 22e9783 to 1f482cd Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Creating test module TC_CADMIN_1_11: - Test module created following matter-test-scripts task (project-chip/matter-test-scripts#286): -- Open commissioning window on DUT twice using ECM then BCM [DUT - Commissionee] -- Commission DUT to TH_CR1 (can be skipped if done in a preceding test) -- TH_CR1 reads the BasicCommissioningInfo attribute from the General Commissioning cluster on EP0 and saves the MaxCumulativeFailsafeSeconds as timeout -- TH_CR1 sends an OpenCommissioningWindow command to the DUT with the CommissioningTimeout set to timeout -- TH_CR2 fully commissions the DUT -- TH_CR1 sends an OpenCommissioningWindow command to the DUT with the CommissioningTimeout set to timeout -- TH_CR1 sends an OpenCommissioningWindow command to the DUT with the CommissioningTimeout set to timeout -- TH_CR2 sends an OpenCommissioningWindow command to the DUT with the CommissioningTimeout set to timeout -- TH_CR1 sends an RevokeCommissioning command to the DUT -- TH_CR1 reads the FeatureMap from the Administrator Commissioning Cluster. If the feature map includes the BC feature bit, repeat steps 5-8 using the OpenBasicCommissioningWindow command -- TH_CR2 reads the CurrentFabricIndex attribute from the Node Operational Credentials cluster and saves as th2_idx -- TH_CR1 sends the RemoveFabric command to the DUT with the FabricIndex set to th2_idx * Restyled by autopep8 * Update tests.yaml * Update TC_CADMIN_1_11.py Updated OpenbasicCommissioningWindow to update to using correct variables. * Updated TC_CADMIN_1_11 test module: - Removed unneccessary count variable due to no longer being needed - Added expectations to TestSteps - Replaced elif with else statements in OpenCommissioningWindow and OpenBasicCommissioningWindow functions - Set busy_enum var using Clusters.AdministratorCommissioning.Enums.StatusCode.kBusy enum value - Changed method to check features for administrator commissioning cluster to check if BC bit value is contained in features * Restyled by autopep8 * Updated TC_CADMIN_1_11: - Removed unneeded prints from the code output * Restyled by autopep8 * Apply suggestions from code review Co-authored-by: C Freeman <cecille@google.com> * Update TC_CADMIN_1_11.py -Added Optional function from typing library to resolve issue with latest code change * Update TC_CADMIN_1_11.py - Due to recent changes, had to update to using PyChipError for ctx.exception.err in order to handle error raised during commissioning properly * Updating TC_CADMIN_1_11: - Updated method for OpenBasicCommissiongWindow with BC feature enabled * Restyled by autopep8 * Update src/python_testing/TC_CADMIN_1_11.py Co-authored-by: C Freeman <cecille@google.com> * Updated TC_CADMIN_1_11 test module: - Removed useTestCommissioner when creating self.th2 - Changed to using None instead of 0 as variable value for OpenCommissioningWindow() - Removed generate_unique_randow_value() as not needed in this test module * Updating TC_CADMIN_1_11 test module: - Resolved linting error * Updated TC_CADMIN_1_11: - Updated due to latest changes to matter_testing support module * Restyled by autopep8 * Removed TC_CADMIN_1_11.yaml and updated TC_CADMIN_1_11: - Removed Test_TC_CADMIN_1_11.yaml - Updated TC_CADMIN_1_11 python test module to enable verbose output in CI/CD pipeline. * Updated TC_CADMIN_1_11 test module: - Updated CI/CD nominclature for this test to match latest version * Updated src/app/tests/suites/manualTests.json: - Removed Test_TC_CADMIN_1_11 from MultipleFabrics section --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: C Freeman <cecille@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.