Split EFR32 tests into separate binaries for each test source file. #34769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld multiple executables for both the chip unit tests and the pigweed internal unit tests.
…changes to the deprecated user-defined-driver feature in case anyone is still using it.
|
Review changes with SemanticDiff. Analyzed 6 of 16 files. Overall, the semantic diff is 7% smaller than the GitHub diff. 1 files do not contain logic changes.
|
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34769: Size comparison from bbef51a to 48709c5 Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34769: Size comparison from bbef51a to ab935e8 Full report (4 builds for cc32xx, mbed, stm32)
|
|
PR #34769: Size comparison from bbef51a to 32d49e6 Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
|
PR #34769: Size comparison from bbef51a to 6f04bde Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…s` and is dep'd by each pw_test
…n lib back into group() target
|
PR #34769: Size comparison from fa29225 to 66bc519 Full report (79 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…he flashbundle for the whole set of tests, and fixed what files get copied to the artifacts directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been replaced by PR #35028.
Pursuant to Issue 33360, this PR splits up the tests for EFR32 into separate flashable binaries for each test source file.
Changes:
$root_output_dir/testswith a filename like "matter-silabs-device_tests_TestSomething.s37".chip_test.gnisince it is no longer used after the transition to pw unit test.chip_test_suiteaccept the variabletests, which adds both a test source and a corresponding custom test driver.Notes:
silabs_executabletarget insrc/test_driver/efr32/BUILD.gn, we setpw_unit_test_EXECUTABLE_TARGET_TYPEto "silabs_executable" and we letpw_testgenerate the executable target.src/test_driver/efr32/BUILD.gndefines a source_set for the test driver, which is dep'd by eachpw_test.silabs_executables. Since these do not defineoutput_name, we set a default value foroutput_name.silabs_executable.gniandflashable_executable.gniare modified to output toinvoker.output_dirinstead ofroot_out_dirso that it's possible to specify a directory besides the root. Ifoutput_diris not defined it will default toroot_out_dir.silabs_executableneeded modification to fix some conflicts that occurred if multiplesilabs_executables are built to the same directory.silabs_firmware_utils.pyandfirmware_utils.pycan't be copied via GN'scopy()any more since multiple tests will need to copy these files into the same output directory ("tests"), and GN won't allow that. So the copying is now done insilabs_firmware_utils.pywhenmake_wrapperis called during the creation of{target}.flash.py.{target}.flashbundle.txtfile can no longer be generated viawrite_runtime_depssince thecopy()target is gone (and would have the wrong output name even if it was there). So the creation of{target}.flashbundle.txtis now done insilabs_firmware_utils.pywhenmake_wrapperis called during the creation of{target}.flash.py.