-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Duplicate MTRDevice with git cp
#34826
Closed
kiel-apple
wants to merge
10
commits into
project-chip:master
from
kiel-apple:darwin-duplicate-mtrdevice-git-cp
Closed
[Darwin] Duplicate MTRDevice with git cp
#34826
kiel-apple
wants to merge
10
commits into
project-chip:master
from
kiel-apple:darwin-duplicate-mtrdevice-git-cp
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. |
PR #34826: Size comparison from 62255da to 0fd5a25 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Aug 7, 2024
…/CHIP/MTRDevice_Concrete.mm
…CHIP/MTRDevice_Concrete.h
0fd5a25
to
52c27fc
Compare
welp |
PR #34826: Size comparison from 4e2245b to 63a7930 Full report (19 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
e4533ba
to
52c27fc
Compare
PR #34826: Size comparison from befc990 to f7d6c80 Full report (50 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
PR #34826: Size comparison from befc990 to 6832eb5 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
auto-merge was automatically disabled
August 8, 2024 06:21
Pull request was closed
Closing this, as this is causing more work than is worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this would help after a merge-squash but here it is.