[PICS-Removal] Removing automatable PICS from ICDM 2 1 test module #34933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed automatable PICS from TC_ICDM_2_1 test module
|
Review changes with Changed Files
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #34933: Size comparison from e994cbf to f74cdc7 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34933: Size comparison from 354464e to 38cdc25 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34933: Size comparison from 10531e1 to 372e144 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Enabling verbose output in CI/CD pipeline to get more context on current issue
|
PR #34933: Size comparison from 10531e1 to 6f9e1e5 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Removed additional print statements from TC_ICDM_2_1 due to no longer needed - Added AttributeList to list of attrs in test_TC_ICDM_2_1 to see if we can get the CI/CD to pass.
|
PR #34933: Size comparison from 10531e1 to 267afbe Increases above 0.2%:
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu and
chulspro
|
PR #34933: Size comparison from acba7f8 to fa944cd Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Sep 20, 2024
src/python_testing/TC_ICDM_2_1.py
Outdated
| self.step(11) | ||
| if self.pics_guard(self.check_pics("ICDM.S.A0009")): | ||
| if attributes.MaximumCheckInBackOff.attribute_id in attribute_list: |
There was a problem hiding this comment.
Same comment here as on the opstate tests - this gets rid of the skip marker. Though this test is already a mixed bag of whether that happens.
There was a problem hiding this comment.
Hi Cecille,
I have created a function in MatterBaseTest class named "attributes_guard" as you had mentioned using the check_attributes function in the matter_testing_scripts helper module.
This should work I hope, please see the update to the issue #370 you have filed and let me know if this will resolve the above comment.
Thank you!
There was a problem hiding this comment.
is that in this PR or a different PR?
There was a problem hiding this comment.
Hi Cecille,
Sorry, the above created attributes_guard function is actually implemented currently in PR #34290 for the Opstate PICS replacement tests.
cecille
removed
the
matter-1.4-te2-script-change
github-actions
bot
added
the
matter-1.4-te2-script-change
|
PR #34933: Size comparison from a3a443a to a629150 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34933: Size comparison from b0d0614 to 07bb37a Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Updating to using attribute_guard()
|
PR #34933: Size comparison from b0d0614 to d7747ed Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Jan 17, 2025
src/python_testing/TC_ICDM_2_1.py
Outdated
| @@ -194,7 +194,7 @@ async def test_TC_ICDM_2_1(self): | |||
|
|
|||
| # Validate ClientsSupportedPerFabric | |||
| self.step(5) | |||
| if self.pics_guard(self.check_pics("ICDM.S.A0005")): | |||
| if await self.attribute_guard(endpoint=self.endpoint, attribute=attributes.ClientsSupportedPerFabric): | |||
There was a problem hiding this comment.
thinking it makes more sense to have this be a non-async function. See _async_runner for the wrapper on how to do that. I don't think you're ever going to want this to be truly async
There was a problem hiding this comment.
It does seem that it makes more sense for it to be non-async, always best to keep things as simple as possible.
Updated using _async_runner as an example, created async_function_runner function in matter_testing support module, this should allow us to call the functions such as attribute_guard inside of tests without having to use await moving forward, instead uses the asyncio.wait_for() and asyncio.run() as needed such as displayed in _async_runner.
Please let me know if this will be ok.
- Updating to remove unneeded if statements for checking mandatory attributes
- Added new function "async_function_runner" to matter_testing support module, allowing async functions to be run synchronously even in the event that another event loop is already running - Updated TC_ICDM_2_1 to using async_function_runner for calling functions such as attribute_guard when not wanted for those to be awaited.
- Resolving linting error
|
PR #34933: Size comparison from 4412d0c to 4618ff4 Full report (3 builds for cc32xx, stm32)
|
|
PR #34933: Size comparison from 57ff3e6 to 1b63d63 Increases above 0.2%:
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Replaced PICS with new async_function_runner function to resolve issue with unit test failing
|
PR #34933: Size comparison from df5ee33 to ddb3488 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing