YAML linter: Add check for manual steps, remove known bad unit tests #35493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 1 of 2 files. Overall, the semantic diff is 1% smaller than the GitHub diff.
|
github-actions
bot
added
scripts
app
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
|
PR #35493: Size comparison from 3f0f242 to 23ee6db Full report (74 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35493: Size comparison from 3f0f242 to 7e9c026 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This reverts commit e3c045d.
|
PR #35493: Size comparison from 728d138 to 0d5d384 Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ReneJosefsen
approved these changes
Oct 23, 2024
arkq
approved these changes
Oct 24, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…roject-chip#35493) * YAML linter: Add check for manual steps, remove known bad unit tests * test bad change * Restyled by isort * Trying again for CI - checkout had no depth * testing - I can't repro locally * ha...removed my test bad test * more testing...ci is different than local and act * debugging in ci...fun times * Restyled by whitespace * let's just run the one, ya? * Fix git on the VM * Actually error though * Revert "let's just run the one, ya?" This reverts commit e3c045d. * Remove the added bad step --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: I added a manual step into one of the smoke CO tests to see the CI fail. The failing run can be viewed here: https://github.com/project-chip/connectedhomeip/actions/runs/11444886657/job/31840767504?pr=35493. This was subsequently removed.
Apologies for the many PRs, the setup on act is slightly different than in the CI so I was testing in the CI.