Actions: Add generic implementation for the actions cluster. #35568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
…ong with name buffer and added events
…of MatterActionsPluginServerInitCallback in example
…dify* to a notification as suggested in the code review.
jadhavrohit924
force-pushed
the
actions
branch
from
f4714e0 to
2e3eb2c
Compare
|
PR #35568: Size comparison from 392909e to 2e3eb2c Full report (18 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, qpg, stm32)
|
jadhavrohit924
force-pushed
the
actions
branch
from
2e3eb2c to
9ec4acf
Compare
|
PR #35568: Size comparison from 5e10345 to 9ec4acf Increases above 0.2%:
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…-chip#35568) * Regenerate zap for actions cluster * Add generic implementation for action cluster * Example changes * Add documentation and fix pipeline * Some example changes * Add comment about scope of name * Restyled by clang-format * Add generic struct to copy the ActionStruct and EndpointListStruct along with name buffer and added events * Address review comments * Fix CI and apps should use emberAfActionsClusterInitCallback instead of MatterActionsPluginServerInitCallback in example * Try to fix CI * Address review changes * Change implementation to accomodate actions server on multiple endpoints. * Restructured the storage structs, command handler and removed vector usage. * Add unit tests for the actions cluster. * Add API to mark dirty attribute and changed delegate impl. * Addressed review changes. * Update the docs, changed API name as suggested, and fix CI for esp32 * Removed the notify delegates API on existing ActionList, EndpointList change. * Fix API signature in linux/bridge-app. * Removed public MatterContext APIs, added todo to remove global delegates array. * Address some minor comments from code review. * Address review comments. * Update API docs, command handling to return InvalidCommand, update Modify* to a notification as suggested in the code review. * Fix clang-tidy validation --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Changes:
Testing: