-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase pairing timeouts in darwin tests. #35698
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:increase-pairing-timeouts
Sep 20, 2024
Merged
Increase pairing timeouts in darwin tests. #35698
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:increase-pairing-timeouts
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had a few test failures where the server app starts up _really_ slowly, to the point that it takes about 10 seconds just to get it started and advertising. And if we're waiting to discover it, 10 seconds is just not long enough to commission if that's how long it takes to start up.
Review changes with SemanticDiff. |
PR #35698: Size comparison from 7b8467b to 4a21e5c Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Sep 20, 2024
nivi-apple
approved these changes
Sep 20, 2024
kiel-apple
approved these changes
Sep 20, 2024
nivi-apple
pushed a commit
to nivi-apple/connectedhomeip
that referenced
this pull request
Sep 24, 2024
We've had a few test failures where the server app starts up _really_ slowly, to the point that it takes about 10 seconds just to get it started and advertising. And if we're waiting to discover it, 10 seconds is just not long enough to commission if that's how long it takes to start up.
nivi-apple
pushed a commit
to nivi-apple/connectedhomeip
that referenced
this pull request
Sep 24, 2024
We've had a few test failures where the server app starts up _really_ slowly, to the point that it takes about 10 seconds just to get it started and advertising. And if we're waiting to discover it, 10 seconds is just not long enough to commission if that's how long it takes to start up.
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
We've had a few test failures where the server app starts up _really_ slowly, to the point that it takes about 10 seconds just to get it started and advertising. And if we're waiting to discover it, 10 seconds is just not long enough to commission if that's how long it takes to start up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a few test failures where the server app starts up really slowly, to the point that it takes about 10 seconds just to get it started and advertising. And if we're waiting to discover it, 10 seconds is just not long enough to commission if that's how long it takes to start up.