[Silabs] Fixing hardfault issue with RS9116 ble manager #36167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #36167: Size comparison from d7abcbf to 980c798 Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
rosahay-silabs
approved these changes
Oct 21, 2024
mkardous-silabs
requested changes
Oct 21, 2024
There was a problem hiding this comment.
As a general comment, do we need to use a global variable for the bleEvent?
osMessageQueuePut copies the the buffer to the queue to not require the user of the API to maintain the initial event data.
We can just create a local variable each time we want to pass an event to the message queue.
| @@ -294,6 +294,7 @@ void SilabsBleWrapper::rsi_ble_add_char_val_att(void * serv_handler, uint16_t ha | |||
|
|
|||
| uint32_t SilabsBleWrapper::rsi_ble_add_matter_service(void) | |||
| { | |||
| bleEvent.eventData = new SilabsBleWrapper::sl_wfx_msg_t(); | |||
There was a problem hiding this comment.
Instead of using dynamic allocation, we could just change the structure type to avoid using a pointer for the eventData. From i can tell, there doesn't seem to be an explicitly requirement and the variable is global.
@mkardous-silabs The reason it can't be saved as a local variable and passed through the queue is that we need the data which is saved in the same struct during the init/previous event data during the some of events. So instead of having multiple global variables it is better to have a single struct. |
@chirag-silabs From what i can see from the code, the only spot where the ble event is used differently is I'm not sure why this would require a global variable. Am i missing something? |
|
This change is not required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The Ble manager for Rs911x devices code refactored by below PR and in this no where the memory is not allocated for bleEvent.eventData member.
#35522
Due to which hardfault is coming when this struct member is getting defined.
Fix
Fixed the issue by allocating
Testing
Tested commissioning with 917 SoC, RS9116+EFR mg24.