Create CHIP-specific backends for pigweed assert and logs #36297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of previous built-in/basic ones. Remove old log backend
github-actions
bot
added
examples
lib
app
config
tests
support
test driver
silabs
labels
github-actions
bot
added
github
workflows
matter-1.4-te2-script-change
|
PR #36297: Size comparison from 22fb834 to c6e0665 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36297: Size comparison from 22fb834 to f23a590 Full report (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
… seems, so wait for the right status (it starts as not open, then switches to open)
tehampson
reviewed
Nov 6, 2024
|
PR #36297: Size comparison from 22fb834 to 8564fa0 Full report (5 builds for cc32xx, qpg, stm32)
|
tehampson
approved these changes
Nov 6, 2024
|
PR #36297: Size comparison from 22fb834 to 3b8a784 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
…ly want to read the files not have them in stdout (except for CI where we only see stdout right now)
|
PR #36297: Size comparison from 22fb834 to 8431a79 Increases above 0.2%:
Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36297: Size comparison from 2af51b0 to 2edeb2e Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
pushed a commit
to andy31415/connectedhomeip
that referenced
this pull request
Nov 7, 2024
Tested locally that `android-arm64-chip-test` builds.
andy31415
added a commit
that referenced
this pull request
Nov 7, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ip#36297) * Add a matter backend for assertions, to not depend on basic assertions in pigweed itself * No nullptr pass * Add a log backend, update copyrights * Restyle * Switch all backends for log and assert to the new chip backends instead of previous built-in/basic ones. Remove old log backend * Update public to fix linter for gn references * Fix dependencies (this should fix boufalolab compile at least * Remove pw_log_basic as we do not use it anymore * Restyle * Remove one more log_basic usage * Fix typo in log type - application is not defined * Avoid infinite recursion on logging now that PW-logging is not used * Remove echo_pb2 from the console as this is already imported by the pw_system.console it seems * Make PWConsole work again * make linter happy * Clean up all usages of CHIP_USE_PW_LOGGING * Mass rename backends to pw_backends * One more rename * Remove some more includes * Allow to keep going and report failed tetsts in local.py * Do not force fabric admin on BLE ... that seems odd * Switch to no wifi on fabric admin/bridge too * More cleanup for sizes for subprocess * More updates, generally switching to textio did not seem to work well, so just set bufsize to 0 * Update logic: apparently readlines is NOT lazy * Remove unused import * Fix unit tests * Even better display and avoid crashes in pw rpc. Sill need to fix mcore test * Fix flag logic * Make MCOREFS_1_5 less racy: window status is updated several times it seems, so wait for the right status (it starts as not open, then switches to open) * Restyled by autopep8 * Ensure elapsed and time remaining is always updated * Make local.py have a less noisy argument since on failures we generally want to read the files not have them in stdout (except for CI where we only see stdout right now) --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Restyled.io <commits@restyled.io>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…#36424) Tested locally that `android-arm64-chip-test` builds. Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we funnel into pigweed basic logging (which uses sys_io (generally stdout) and does not hook into general chip logging) and asserts are not using chip assert macros.
This would allow us to eventually use more of pigweed generic modules (e.g. bytes, base64, functions) without losing matter module integration.
Changes
keep-goingto locals.py to support debugging failing testshost.pyto fully disable BLE on noble (since it seems otherwise we could disable the BLE layer while enabling BLE, which makes no sense)