[ESP32] Platform diagnostics framework #36532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimpalemahesh
force-pushed
the
platform_diagnostics
branch
from
5ef9201 to
97d0be3
Compare
pimpalemahesh
force-pushed
the
platform_diagnostics
branch
2 times, most recently
from
a93a065 to
7178050
Compare
|
PR #36532: Size comparison from 61e288a to 7178050 Full report (3 builds for cc32xx, stm32)
|
pimpalemahesh
force-pushed
the
platform_diagnostics
branch
3 times, most recently
from
667abcd to
ed14abb
Compare
|
PR #36532: Size comparison from 61e288a to ed14abb Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Would have been helpful if something in the PR title or description made it clear this is esp32-only... |
pimpalemahesh
changed the title
pimpalemahesh
force-pushed
the
platform_diagnostics
branch
from
ed14abb to
6571c5e
Compare
|
PR #36532: Size comparison from d8ededa to 6571c5e Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shubhamdp
reviewed
Nov 19, 2024
examples/temperature-measurement-app/esp32/main/diagnostic-logs-provider-delegate-impl.cpp
Outdated
Show resolved
Hide resolved
...ples/temperature-measurement-app/esp32/main/include/diagnostic-logs-provider-delegate-impl.h
Outdated
Show resolved
Hide resolved
...ples/temperature-measurement-app/esp32/main/include/diagnostic-logs-provider-delegate-impl.h
Outdated
Show resolved
Hide resolved
pimpalemahesh
force-pushed
the
platform_diagnostics
branch
from
9e148bb to
1ce3585
Compare
|
PR #36532: Size comparison from 0ac52eb to 1ce3585 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
pimpalemahesh
force-pushed
the
platform_diagnostics
branch
from
1ce3585 to
eb088ab
Compare
|
PR #36532: Size comparison from ffbc362 to eb088ab Full report (3 builds for cc32xx, stm32)
|
pimpalemahesh
force-pushed
the
platform_diagnostics
branch
2 times, most recently
from
ca96506 to
ba3ac54
Compare
pimpalemahesh
force-pushed
the
platform_diagnostics
branch
from
ba3ac54 to
a98b1f8
Compare
|
PR #36532: Size comparison from ffbc362 to a98b1f8 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36532: Size comparison from b56134c to 5bb73f2 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, stm32, telink, tizen)
|
- Working backend with metric, trace and counter diagnostics - Diagnostic interface implementation with ring buffer storage - Added option ENABLE_ESP_DIAGNOSTICS_TRACE in chip KConfig - Added required options for enabling matter diagnostic trace in project Kconfig
- Resolve buffer issues - Use single buffer for store and retrieve of diagnostics - Resolve data loss issue
…essary comments, format files, namespace changes
- backend: Replace linkedlist with map for counter diagnostics - backend: Pass diagnostic storage as a parameter to backend - esp32_diagnostic_trace: Return actual data size
- esp32_diagnostic_trace: improve storage class design - add extra tlv closing bytes check before copying diagnostic - unify diagnostic entries into a single type
- Add related logic in temperature-measurement-app
- Add private CircularTLVReader and CircularTLVWriter - Remove redundant outer container for tlv's from Retrieve method - Maintain TAG's for diagnostic entry elements - Make diagnostic entry as a constant param to store method - Move Murmurhash to utils namespace
…gnostics - move diagnostic storage buffer to main
…ter to LogProvider - add kconfig option for retrieval buffer size
- pass diagnostic storage instance as a pointer to backend - replace ESPLog statement with ChipLog for logging diagnostic-storage: update IsEmptyBuffer method to IsBufferEmpty - change diagnostic TAG enum class
pimpalemahesh
force-pushed
the
platform_diagnostics
branch
3 times, most recently
from
76ac873 to
81a92a8
Compare
pimpalemahesh
force-pushed
the
platform_diagnostics
branch
from
81a92a8 to
b4f724e
Compare
|
PR #36532: Size comparison from c1506f3 to b4f724e Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The existing implementation lacks the ability to collect diagnostics using the diagnostic-logs cluster.
Change Overview
Platform Diagnostic Framework:
Designed to collect, store, and retrieve diagnostic data.
Implemented new backend:
Diagnostic data collection integrated using Matter Traces.
Diagnostic data is stored in a TLVCircularBuffer for efficient memory utilization.
Integration with the Temperature Measurement App for platform esp32.
Testing
Verified commissioning and retrieval of diagnostics using the diagnostic-logs cluster over BDX on the ESP32-C3 chip with the temperature-measurement-app example.