Enabled most unit tests for ESP32 #36626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36626: Size comparison from 9d60489 to 251a839 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36626: Size comparison from 9d60489 to c9301c2 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36626: Size comparison from 9d60489 to 36b73dc Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Are you sure about your PR title? |
feasel0
changed the title
|
Fixed PR title and added description. |
andy31415
approved these changes
Nov 25, 2024
|
due to this check, the tests will be skipped in the CI. Should we remove that |
dhrishi
reviewed
Nov 28, 2024
If we want to run the qemu tests on the PR itself, the check should be removed. Also the CI related to QEMU should be tested on this PR before merging this. So , even if we wish to skip the test and run it on espressif/connectedhomeip CI, the changes should specific to QEMU should be tested on this PR. |
|
I removed the condition, which enabled the two esp32 workflows, and confirmed that this PR does pass CI. Before merging, I can revert it to the previous state (only runs on PRs from esspressif) if that's how we prefer to have it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been replaced by PR 36738 in order to correct the commit message