Add return value check for avoid interger overflow #36686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36686: Size comparison from e402b96 to 9027b33 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Dec 2, 2024
|
PR #36686: Size comparison from a3a443a to 0935eac Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36686: Size comparison from a3a443a to 97122e3 Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
myddpp
force-pushed
the
fix_dnssd_INTEGER_OVERFLOW
branch
from
97122e3 to
e8d05e4
Compare
- Changed the initial value of max to 1 within the function. - If max is not updated during the for loop, it returns -1, which can cause an INTEGER_OVERFLOW - By initializing max to 1, it ensures that if max is updated during the loop, the updated value is used. - If no value is updated, it performs the -1 operation and updates to 0.
myddpp
force-pushed
the
fix_dnssd_INTEGER_OVERFLOW
branch
from
e8d05e4 to
9a014b9
Compare
|
PR #36686: Size comparison from a3a443a to 9a014b9 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Dec 3, 2024
bzbarsky-apple
approved these changes
Dec 5, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
- Changed the initial value of max to 1 within the function. - If max is not updated during the for loop, it returns -1, which can cause an INTEGER_OVERFLOW - By initializing max to 1, it ensures that if max is updated during the loop, the updated value is used. - If no value is updated, it performs the -1 operation and updates to 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid overflowed constant(INTEGER_OVERFLOW) occurrence, minus operation is performed only when the value is greater than 0