[Silabs] Fix Test Event Trigger processing #36981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #36981: Size comparison from e7f6d0e to 8e2664c Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
force-pushed
the
fix/test_event_trigger
branch
from
d98fd60 to
168cd50
Compare
jmartinez-silabs
approved these changes
Jan 9, 2025
jmartinez-silabs
added
the
changing-submodules-on-purpose
|
PR #36981: Size comparison from f044060 to 9fb1053 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
approved these changes
Jan 13, 2025
examples/platform/silabs/test-event-trigger/SilabsTestEventTriggerDelegate.cpp
Show resolved
Hide resolved
feasel0
reviewed
Jan 17, 2025
examples/platform/silabs/test-event-trigger/SilabsTestEventTriggerDelegate.h
Outdated
Show resolved
Hide resolved
feasel0
reviewed
Jan 17, 2025
feasel0
reviewed
Jan 17, 2025
feasel0
approved these changes
Jan 17, 2025
mkardous-silabs
force-pushed
the
fix/test_event_trigger
branch
from
b4d2a1a to
b7db67e
Compare
|
PR #36981: Size comparison from f7226c1 to 380aa60 Full report (21 builds for bl602, bl702, bl702l, cc13x4_26x4, esp32, nrfconnect, nxp, stm32)
|
mkardous-silabs
force-pushed
the
fix/test_event_trigger
branch
from
380aa60 to
e521b43
Compare
lpbeliveau-silabs
approved these changes
Feb 10, 2025
|
PR #36981: Size comparison from e86768b to eee6086 Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
force-pushed
the
fix/test_event_trigger
branch
from
eee6086 to
80454fe
Compare
|
PR #36981: Size comparison from e86768b to 51363cc Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
force-pushed
the
fix/test_event_trigger
branch
from
51363cc to
71194c8
Compare
|
PR #36981: Size comparison from b99f977 to 71194c8 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Feb 12, 2025
andy31415
approved these changes
Feb 12, 2025
|
PR #36981: Size comparison from 408fa74 to da9c96a Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36981: Size comparison from 408fa74 to 4295151 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
ratgr
pushed a commit
to ratgr/connectedhomeip
that referenced
this pull request
Feb 26, 2025
* Refactor Test Event trigger support * fixup! Refactor Test Event trigger support * Fix ota encryption key preprocessor macro * Remove ProvisionManager header * Update submodule to the lastest * Pull matter_support changes * Add platform enable test build argument * Add silabs runner * Fix test event trigger function * Fix provision flash
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
* Refactor Test Event trigger support * fixup! Refactor Test Event trigger support * Fix ota encryption key preprocessor macro * Remove ProvisionManager header * Update submodule to the lastest * Pull matter_support changes * Add platform enable test build argument * Add silabs runner * Fix test event trigger function * Fix provision flash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the SDK check if the test event trigger is enabled, it checks if the test event trigger enableKey is equal to a zero Bytespan. If the enableKey matches, returns false that the feature is not enabled.
In the current implementation, if we fail to read the enable key, we immediatly return that the key does not match. If the key we are trying to match was the zero bytespan, this triggers the stack to think the feature is enabled since the platform enable key does not match the zero bytepspan which is incorrect.
The other issue was that we return that the enableKeys don't match if !enableKeySpan.empty() . When checking with the zero bytespan, this returns false immediatly without checking the platform enable key,
The PR changes the logic to always check if the data matches or not which, trough the bytespan function, covers all the edge cases.
PR also does a small cleanup of the provisioning test event trigger related code.
PR adds the silabs examples tests directory to the list of test directories
Platform Unit testing
PR adds the framework to enable platform to a their unit tests to the CI runs.
The enable gn argument can be used to gate and enable all platform tests without requiring devs to have all the necessary components.
A unit test platform was added to allow the CI to checkout necessary repositories.
Testing