[ESP32]Init openthread stack after server init in example #37073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
Jerry-ESP
force-pushed
the
esp32/init_openthread_after_server_init
branch
from
b0ee3a9 to
b2d896f
Compare
|
PR #37073: Size comparison from 4baf343 to b2d896f Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jan 15, 2025
bzbarsky-apple
approved these changes
Jan 15, 2025
wqx6
approved these changes
Jan 16, 2025
|
PR #37073: Size comparison from 9b58c27 to 759099b Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original logic, the data model provider was initialized after the OpenThread stack was initialized. However, during Thread network connection after OpenThread initialization, the content initialized by the data model provider would be invoked, but at that time, it had not yet been initialized, which could lead to a crash. Therefore, in this PR, the OpenThread stack initialization is moved to occur after the data model provider initialization.
Note: Fix the error logic in PR:#37059
Testing
Tested on lighting-app example with esp32h2, after pairing with ble-thread, then reset the device, the device can run without crash.