ESP32: Add OTA function for thread border router device #37099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
Jerry-ESP
force-pushed
the
esp32/add_thread_br_ota
branch
2 times, most recently
from
7ae5070 to
fad010a
Compare
Jerry-ESP
force-pushed
the
esp32/add_thread_br_ota
branch
3 times, most recently
from
668d121 to
6851717
Compare
|
PR #37099: Size comparison from d7e30d0 to 6851717 Full report (3 builds for cc32xx, stm32)
|
Jerry-ESP
force-pushed
the
esp32/add_thread_br_ota
branch
from
6851717 to
c13b4f4
Compare
|
PR #37099: Size comparison from f3e4e39 to c13b4f4 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37099: Size comparison from 593861d to ad949c7 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37099: Size comparison from b02badf to 2f0bce1 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Jerry-ESP
force-pushed
the
esp32/add_thread_br_ota
branch
from
2f0bce1 to
f487cc2
Compare
|
PR #37099: Size comparison from 1348a8a to 28f443f Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
chshu
reviewed
Feb 11, 2025
| @@ -92,3 +93,15 @@ the Thread network. | |||
| ``` | |||
| ./chip-tool pairing ble-wifi 2 hex:<dataset_tlvs> <pincode> <discriminator> | |||
| ``` | |||
|
|
|||
| ### Generate OTA Firmware For BR | |||
There was a problem hiding this comment.
Users don't need to do this manually, the esp_rcp_update component will do this automatically if option RCP_PARTITION_NAME is enabled.
There was a problem hiding this comment.
Could we do it automatically when CHIP_OTA_IMAGE_BUILD is enabled?
| ota_1, app, ota_1, , 1800K, | ||
| rcp_fw, data, spiffs, , 300K, | ||
| ota_0, app, ota_0, , 1700k, | ||
| ota_1, app, ota_1, , 1600k, |
There was a problem hiding this comment.
The size of ota_0 and ota_1 should be the same?
| @@ -29,8 +29,9 @@ CONFIG_BT_NIMBLE_ENABLE_CONN_REATTEMPT=n | |||
|
|
|||
| # Increase some stack size | |||
| CONFIG_ESP_SYSTEM_EVENT_TASK_STACK_SIZE=7200 | |||
| CONFIG_ESP_MAIN_TASK_STACK_SIZE=5120 | |||
| CONFIG_ESP_MAIN_TASK_STACK_SIZE=10240 | |||
There was a problem hiding this comment.
Could you double check if this change is necessary, 10K is too large..
| @@ -196,8 +196,18 @@ static void try_update_ot_rcp(const esp_openthread_platform_config_t * config) | |||
| static void rcp_failure_handler(void) | |||
| { | |||
| esp_rcp_mark_image_unusable(); | |||
| try_update_ot_rcp(s_platform_config); | |||
| esp_rcp_reset(); | |||
| char internal_rcp_version[kRcpVersionMaxSize]; | |||
There was a problem hiding this comment.
Let's try esp_rcp_reset() first, RCP update or restart should be used only when esp_rcp_reset() can't recover it.
Jerry-ESP
force-pushed
the
esp32/add_thread_br_ota
branch
from
28f443f to
6b97dd6
Compare
Jerry-ESP
force-pushed
the
esp32/add_thread_br_ota
branch
from
6b97dd6 to
6c4ea89
Compare
|
PR #37099: Size comparison from 0bae36f to 7d42b64 Full report (71 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
wqx6
reviewed
Mar 17, 2025
|
|
||
| #if defined(CONFIG_AUTO_UPDATE_RCP) && defined(CONFIG_OPENTHREAD_BORDER_ROUTER) | ||
| esp_rcp_ota_handle_t mRcpOtaHandle; | ||
| bool mRcpDone; |
There was a problem hiding this comment.
Better to rename it to mRcpFirmwareDownloaded.
| @@ -92,3 +93,15 @@ the Thread network. | |||
| ``` | |||
| ./chip-tool pairing ble-wifi 2 hex:<dataset_tlvs> <pincode> <discriminator> | |||
| ``` | |||
|
|
|||
| ### Generate OTA Firmware For BR | |||
There was a problem hiding this comment.
Could we do it automatically when CHIP_OTA_IMAGE_BUILD is enabled?
| @@ -280,6 +280,37 @@ esp_err_t OTAImageProcessorImpl::DeltaOTAWriteCallback(const uint8_t * buf, size | |||
| } | |||
| #endif // CONFIG_ENABLE_DELTA_OTA | |||
|
|
|||
| #if defined(CONFIG_AUTO_UPDATE_RCP) && defined(CONFIG_OPENTHREAD_BORDER_ROUTER) | |||
| esp_err_t OTAImageProcessorImpl::ProcessRcpImage(intptr_t context, const uint8_t * buffer, uint32_t bufLen) | |||
There was a problem hiding this comment.
Why do we use a context for an OTAImageProcessorImpl in a non-static function? Please use this instead.
Jerry-ESP
force-pushed
the
esp32/add_thread_br_ota
branch
from
2a0471b to
cd39362
Compare
Jerry-ESP
force-pushed
the
esp32/add_thread_br_ota
branch
from
cd39362 to
1a51dfe
Compare
|
PR #37099: Size comparison from 79da246 to c6a1c74 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OTA function for Thread border, the OTA firmware include both Thread BR's firmware and RCP's firmware.
Testing
Tested on thread_br_app example for esp32