Cancel the periodic Time Sync timer in Matter.framework when the controller is suspended. #37230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
woody-apple
approved these changes
Jan 27, 2025
|
PR #37230: Size comparison from 39fc790 to e1e4fd3 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
force-pushed
the
cancel-time-sync-timer-on-suspend
branch
from
e1e4fd3 to
da17a3c
Compare
|
PR #37230: Size comparison from ddf6e2f to da17a3c Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
force-pushed
the
cancel-time-sync-timer-on-suspend
branch
from
da17a3c to
acf4363
Compare
|
PR #37230: Size comparison from 4593aef to acf4363 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…roller is suspended. We shouldn't be trying to talk to the device in that state.
bzbarsky-apple
force-pushed
the
cancel-time-sync-timer-on-suspend
branch
from
acf4363 to
997932d
Compare
|
PR #37230: Size comparison from 0e47155 to 997932d Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be trying to talk to the device in that state.
Testing
Manual testing with a shorter timer, because we don't want CI that takes 24 hours.