-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TC-CC-8.1] Update test to automate steps #37335
base: master
Are you sure you want to change the base?
Conversation
Diego Martin Maranges seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
6d4f75e
to
40ee0e1
Compare
PR #37335: Size comparison from 4f956ec to 40ee0e1 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
40ee0e1
to
450afcd
Compare
PR #37335: Size comparison from 58c6789 to 450afcd Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM however if it depends on https://github.com/CHIP-Specifications/chip-test-plans/pull/4933 we should probably wait for that one to merge.
ef915f3
to
7144c5c
Compare
PR #37335: Size comparison from 7adac6e to 7144c5c Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to ignore the concept of wraparound of the CurrentHue variable.
Should not be merged in this state
39d167b
to
3d7a5b0
Compare
PR #37335: Size comparison from 33aec35 to 3d7a5b0 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #37335: Size comparison from 33aec35 to c456b83 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM however if it depends on CHIP-Specifications/chip-test-plans#4933 we should probably wait for that one to merge.
@andy31415 @dmaranges-gd the referred PR 4933 concerns TC-CC-3.1 while this PR makes changes in TC-CC-8.1 . So we first need a PR for the test plan of TC-CC-8.1 (in the same style as 4933) before we can make any changes to the yaml here
This PR updates TC-CC-8.1.yaml file. This PR is linked to Fixes #477. Follow the same characteristics to PR 37308.
I modified the wait time from 10s to 20s. In 20s, the value will increase from 200 to 300 (mod 255 = 45). That is to say, it will have a variation of 100 units with a tolerance of 15% (+/- 15) then the expected result it was between 20 an 60.
Updates:
Testing:
To run it follow the same instruction described on the PR 37308 but modifying the last command to:
./scripts/tests/chipyaml/chiptool.py tests Test_TC_CC_8_1 --server_path ./out/linux-x64-chip-tool/chip-tool