Move OnboardingCodesUtil out of app/server #37401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
adigie
force-pushed
the
toup-build-opt
branch
from
a4df653 to
445eb31
Compare
|
PR #37401: Size comparison from 577b3f2 to 445eb31 Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, telink, tizen)
|
adigie
force-pushed
the
toup-build-opt
branch
from
445eb31 to
e9170fb
Compare
adigie
force-pushed
the
toup-build-opt
branch
4 times, most recently
from
0101630 to
66fc382
Compare
github-actions
bot
added
examples
platform
linux
controller
telink
silabs
nxp
adigie
force-pushed
the
toup-build-opt
branch
from
66fc382 to
d5184df
Compare
andy31415
reviewed
Feb 5, 2025
andy31415
reviewed
Feb 5, 2025
adigie
force-pushed
the
toup-build-opt
branch
from
d5184df to
d52286c
Compare
adigie
force-pushed
the
toup-build-opt
branch
from
d52286c to
1bd0296
Compare
|
PR #37401: Size comparison from a998bf6 to 3d4746e Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, qpg, stm32, telink, tizen)
|
adigie
force-pushed
the
toup-build-opt
branch
from
3d4746e to
8c50292
Compare
adigie
force-pushed
the
toup-build-opt
branch
2 times, most recently
from
09b20d3 to
962ad8f
Compare
adigie
changed the title
adigie
force-pushed
the
toup-build-opt
branch
from
e53d023 to
426db4c
Compare
|
PR #37401: Size comparison from 7adac6e to 426db4c Full report (17 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
shubhamdp
approved these changes
Feb 6, 2025
adigie
force-pushed
the
toup-build-opt
branch
from
426db4c to
ff36e43
Compare
|
PR #37401: Size comparison from 7adac6e to ff36e43 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Feb 6, 2025
* Move OnboardingCodesUtils to separate target. * Remove shell dependency on server. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Use PlatformMgr directly. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
adigie
force-pushed
the
toup-build-opt
branch
from
ff36e43 to
4d93f88
Compare
Damian-Nordic
approved these changes
Feb 7, 2025
pimpalemahesh
pushed a commit
to pimpalemahesh/connectedhomeip
that referenced
this pull request
Feb 12, 2025
* Move OnboardingCodesUtil out of server * Move OnboardingCodesUtils to separate target. * Remove shell dependency on server. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [mw320] Remove shell dependency on app/server Use PlatformMgr directly. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [NXP][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [linux][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [Infineon][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Feb 28, 2025
* Move OnboardingCodesUtil out of server * Move OnboardingCodesUtils to separate target. * Remove shell dependency on server. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [mw320] Remove shell dependency on app/server Use PlatformMgr directly. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [NXP][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [linux][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [Infineon][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…ip#37401) * Move OnboardingCodesUtil out of server * Move OnboardingCodesUtils to separate target. * Remove shell dependency on server. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [mw320] Remove shell dependency on app/server Use PlatformMgr directly. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [NXP][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [linux][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [Infineon][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> (cherry picked from commit b959364)
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
* Move OnboardingCodesUtil out of server * Move OnboardingCodesUtils to separate target. * Remove shell dependency on server. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [mw320] Remove shell dependency on app/server Use PlatformMgr directly. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [NXP][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [linux][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [Infineon][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Tested using automated tests.