Adding the level control to light switch and changing to dimmer switch #37448
+1,512
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37448: Size comparison from 2a77a11 to 284339d Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37448: Size comparison from 2a77a11 to c8a849b Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Feb 7, 2025
| @@ -4402,31 +4402,31 @@ | |||
| }, | |||
| { | |||
| "id": 2, | |||
| "name": "MA-onofflightswitch", | |||
| "name": "MA-dimmerswitch", | |||
There was a problem hiding this comment.
Just raising attention that this is a common zap file for a few other platform light-switch app. They might be ok with this addition.
If not we can create zap file specific for silab's light-switch app.
chirag-silabs
force-pushed
the
bugfix/add_dimmer_switch
branch
from
c8a849b to
c0a9ea1
Compare
|
PR #37448: Size comparison from a373044 to 42e2756 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37448: Size comparison from b205837 to 873f9d4 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@chirag-silabs Doesn't button 0 work with these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving the light-switch-app type from onofflightswitch to the dimmerswitch to add the level control client functionality which can be controlled by the light switch app directly.
The button implementation in dimmer switch app by adding level control actions on button sequences. Below are the implementation details :
Default Step direction - Up
Button1 short press - light toggle
Button1 long press - Level up/down as per direction
Button1 shortpress + Button0 shortpress - reverse the direction (down to up or up to down)
Button0 longpress - Factory reset
Testing
Tested on the silabs platform, with the help of shell sending commands of level control to other device
Tested the button sequences on SOC manually for the btn checks