[Docker] Add terms and conditions app to chip-cert-bins image #37474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the terms and conditions application binary to the chip-cert-bins Docker image build for both x64 and arm64 architectures. This change includes: - Adding build target for terms-and-conditions app - Copying the built binary to the final image - Adding environment variable reference in CI test configuration This addition will support upcoming CI test requirements for the terms and conditions functionality.
|
Review changes with Changed Files
|
|
PR #37474: Size comparison from 4c1a0c5 to 3dc64b8 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Feb 7, 2025
|
NOTE: as a followup, these should be compiled with the appropriate flags (ipv6only for TH, no-ble-no-wifi etc. for CI) |
koosc
approved these changes
Feb 7, 2025
chrisdecenzo
approved these changes
Feb 7, 2025
pimpalemahesh
pushed a commit
to pimpalemahesh/connectedhomeip
that referenced
this pull request
Feb 12, 2025
…t-chip#37474) Add the terms and conditions application binary to the chip-cert-bins Docker image build for both x64 and arm64 architectures. This change includes: - Adding build target for terms-and-conditions app - Copying the built binary to the final image - Adding environment variable reference in CI test configuration This addition will support upcoming CI test requirements for the terms and conditions functionality.
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Feb 28, 2025
…t-chip#37474) Add the terms and conditions application binary to the chip-cert-bins Docker image build for both x64 and arm64 architectures. This change includes: - Adding build target for terms-and-conditions app - Copying the built binary to the final image - Adding environment variable reference in CI test configuration This addition will support upcoming CI test requirements for the terms and conditions functionality.
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…t-chip#37474) Add the terms and conditions application binary to the chip-cert-bins Docker image build for both x64 and arm64 architectures. This change includes: - Adding build target for terms-and-conditions app - Copying the built binary to the final image - Adding environment variable reference in CI test configuration This addition will support upcoming CI test requirements for the terms and conditions functionality.
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…t-chip#37474) Add the terms and conditions application binary to the chip-cert-bins Docker image build for both x64 and arm64 architectures. This change includes: - Adding build target for terms-and-conditions app - Copying the built binary to the final image - Adding environment variable reference in CI test configuration This addition will support upcoming CI test requirements for the terms and conditions functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the terms and conditions application binary to the chip-cert-bins Docker image build for both x64 and arm64 architectures. This change includes:
This addition will support upcoming CI test requirements for the terms and conditions functionality.
Testing
The CI build will be used to validate the correctness of the change.