Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC_CGEN_2_8] Add TC acknowledgement attribute verification steps #37498

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[TC_CGEN_2_8] Add TC acknowledgement attribute verification steps #37498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/python_testing/TC_CGEN_2_8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ def steps_TC_CGEN_2_8(self) -> list[TestStep]:
TestStep(5, "DUT is factory reset."),
TestStep(6, "Perform the necessary actions to put the DUT into a commissionable state."),
TestStep(7, "TH begins commissioning the DUT and performs the steps 'Device discovery and establish commissioning channel' through 'Security setup using CASE', skipping 'Configure information- TC Acknowledgements'"),
TestStep(8, "TH sends CommissioningComplete to DUT."),
TestStep(8, "TH reads from the DUT the attribute TCAcceptedVersion."),
TestStep(9, "TH reads from the DUT the attribute TCAcknowledgements."),
TestStep(10, "TH reads from the DUT the attribute TCAcknowledgementsRequired."),
TestStep(11, "TH sends CommissioningComplete to DUT."),
]

@async_test_body
Expand Down Expand Up @@ -147,8 +150,26 @@ async def test_TC_CGEN_2_8(self):
self.matter_test_config.tc_user_response_to_simulate = None
await self.commission_devices()

# Step 8: Verify CommissioningComplete fails
# Step 8: Verify that TCAcceptedVersion equals 0
self.step(8)
response = await commissioner.ReadAttribute(nodeid=self.dut_node_id, attributes=[(ROOT_ENDPOINT_ID, Clusters.GeneralCommissioning.Attributes.TCAcceptedVersion)])
accepted_version = response[ROOT_ENDPOINT_ID][Clusters.GeneralCommissioning][Clusters.GeneralCommissioning.Attributes.TCAcceptedVersion]
asserts.assert_equal(accepted_version, 0, "TCAcceptedVersion does not match expected value.")

# Step 9: Verify that TCAcknowledgements equals 0
self.step(9)
response = await commissioner.ReadAttribute(nodeid=self.dut_node_id, attributes=[(ROOT_ENDPOINT_ID, Clusters.GeneralCommissioning.Attributes.TCAcknowledgements)])
acknowledgements = response[ROOT_ENDPOINT_ID][Clusters.GeneralCommissioning][Clusters.GeneralCommissioning.Attributes.TCAcknowledgements]
asserts.assert_equal(acknowledgements, 0, "TCAcknowledgements does not match expected value.")

# Step 10: Verify that TCAcknowledgementsRequired equals True
self.step(10)
response = await commissioner.ReadAttribute(nodeid=self.dut_node_id, attributes=[(ROOT_ENDPOINT_ID, Clusters.GeneralCommissioning.Attributes.TCAcknowledgementsRequired)])
tc_acknowledgements_required = response[ROOT_ENDPOINT_ID][Clusters.GeneralCommissioning][Clusters.GeneralCommissioning.Attributes.TCAcknowledgementsRequired]
asserts.assert_equal(tc_acknowledgements_required, True, "TCAcknowledgementsRequired should be True.")

# Step 11: Verify CommissioningComplete fails
self.step(11)
response = await commissioner.SendCommand(
nodeid=self.dut_node_id,
endpoint=ROOT_ENDPOINT_ID,
Expand Down
Loading