Hash SSIDs before logging them. #37524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37524: Size comparison from 9c8cb33 to 878b444 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
approved these changes
Feb 11, 2025
woody-apple
requested changes
Feb 11, 2025
| chip::Encoding::BytesToHex(hashedValue, sizeof(hashedValue), hexValue, sizeof(hexValue), chip::Encoding::HexFlags::kUppercase); | ||
| ssidString = [[NSString alloc] initWithBytes:hexValue | ||
| length:sizeof(hexValue) | ||
| encoding:NSUTF8StringEncoding]; |
There was a problem hiding this comment.
Why not just [string hash] per discussion? This is awfully complicated/expensive (not that the cost matters), what's the value here?
There was a problem hiding this comment.
As I said in the discussion if you do [string hash] then to check whether a given SSID is the one that went through this code you have to run [string hash] on the exact same operating system version of the same operating system as the one that created the log, no?
woody-apple
requested changes
Feb 13, 2025
| chip::Encoding::BytesToHex(hashedValue, sizeof(hashedValue), hexValue, sizeof(hexValue), chip::Encoding::HexFlags::kUppercase); | ||
| ssidString = [[NSString alloc] initWithBytes:hexValue | ||
| length:sizeof(hexValue) | ||
| encoding:NSUTF8StringEncoding]; |
|
Per discussion: logging the SSID here is not actually useful, so we'll just stop doing that: #37576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Logging changes only.