[bouffalo lab] Advertise commissionable on last fabric removal is disabled by default #37531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
wy-hh
force-pushed
the
fabric-delegate
branch
from
16f13e2 to
b3738c2
Compare
|
PR #37531: Size comparison from e5a49c8 to b3738c2 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Feb 12, 2025
andy31415
approved these changes
Feb 12, 2025
wy-hh
force-pushed
the
fabric-delegate
branch
from
b3738c2 to
c9ee3ee
Compare
|
PR #37531: Size comparison from a3f941a to c9ee3ee Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
wy-hh
changed the title
wy-hh
force-pushed
the
fabric-delegate
branch
from
cc9b25e to
12dc937
Compare
wy-hh
changed the title
|
PR #37531: Size comparison from 92f9f0b to 12dc937 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Feb 14, 2025
wy-hh
added a commit
to wy-hh/connectedhomeip
that referenced
this pull request
Feb 15, 2025
…abled by default (project-chip#37531) * [bouffalo lab] Make it possible for application to implement its own fabric delegate * Advertise commissionable on last fabric removal is disabled by default
wy-hh
added a commit
to wy-hh/connectedhomeip
that referenced
this pull request
Feb 15, 2025
…abled by default (project-chip#37531) * [bouffalo lab] Make it possible for application to implement its own fabric delegate * Advertise commissionable on last fabric removal is disabled by default
wy-hh
added a commit
to wy-hh/connectedhomeip
that referenced
this pull request
Feb 15, 2025
…abled by default (project-chip#37531) * [bouffalo lab] Make it possible for application to implement its own fabric delegate * Advertise commissionable on last fabric removal is disabled by default
wy-hh
added a commit
to bouffalolab/bflb-connectedhomeip
that referenced
this pull request
Feb 15, 2025
…config littlefs & header reserved size, and update script to generate DAC & MFD (#2) * [bouffalo lab] update scripts and documents to support more options t… (project-chip#37454) * [bouffalo lab] update scripts and documents to support more options to generate and download test mfd * Restyled by prettier-markdown * Restyled by autopep8 * Restyled by isort * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <commits@restyled.io> * [bouffalolab] update macro define for header reserve size and etherne… (project-chip#37516) * [bouffalolab] update macro define for header reserve size and ethernet zap configuration * re-generate lighting-app-ethernet.matter * [bouffalo lab] open commission window when last fabric is removed (project-chip#37517) * [bouffalo lab] open commission window when last fabric is removed * Restyled by whitespace * fix compile error --------- Co-authored-by: Restyled.io <commits@restyled.io> * [bouffalo lab] fix wifi scan issues and update some platform changes (project-chip#37455) * [bouffalo lab] fix wifi scan issues and update some platform changes * Restyled by clang-format * Restyled by gn * Restyled by clang-format * fix wifi scan on bl706 + bl602 platform * Restyled by whitespace * Restyled by clang-format * use strncpy to copy ssid * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io> * [bouffalo lab] Advertise commissionable on last fabric removal is disabled by default (project-chip#37531) * [bouffalo lab] Make it possible for application to implement its own fabric delegate * Advertise commissionable on last fabric removal is disabled by default --------- Co-authored-by: Restyled.io <commits@restyled.io>
ratgr
pushed a commit
to ratgr/connectedhomeip
that referenced
this pull request
Feb 26, 2025
…abled by default (project-chip#37531) * [bouffalo lab] Make it possible for application to implement its own fabric delegate * Advertise commissionable on last fabric removal is disabled by default
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…abled by default (project-chip#37531) * [bouffalo lab] Make it possible for application to implement its own fabric delegate * Advertise commissionable on last fabric removal is disabled by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect to advertise commissionable on last fabric removal with MACRO
CONFIG_APP_ADVERTISE_COMMISSIONABLE_ON_LAST_FABRIC_REMOVALand set it to0by default.Application needs explicitly define
CONFIG_APP_ADVERTISE_COMMISSIONABLE_ON_LAST_FABRIC_REMOVALto1to enable this function.Testing
CONFIG_APP_PAIRING_START_ON_LAST_FABRIC_REMOVALworks well